Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

word order for causal_words_pred #29

Closed
bnicenboim opened this issue Mar 2, 2025 · 1 comment
Closed

word order for causal_words_pred #29

bnicenboim opened this issue Mar 2, 2025 · 1 comment

Comments

@bnicenboim
Copy link
Collaborator

@lisalevinson is concerned that the word order depends on row order:

ropensci/software-review#575 (comment)

Another concern is about the word/token order within groups/sentences. The word context/prefix is based purely on row order? It doesn't seem like the wordn value is used at all. This seems fragile if tokens possibly get sorted/rearranged, and it might not be an obvious problem if one is not carefully inspecting the order of tokens in the outputs. I know usually it will be fine but I always am nervous when anything in data analysis crucially depends on row order.

@bnicenboim
Copy link
Collaborator Author

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant