Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_oikt_type field with a selected value of 0 (CD) is not displayed by bw_fields or sb-field-block #40

Open
bobbingwide opened this issue Dec 15, 2024 · 1 comment
Assignees

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Dec 15, 2024

On the new version of the website for Official Caravan, when viewing the Recording type ( _oikt_type ) for https://s.b/officialcaravan/blog/oik-recording/paradise-filter/ no value is displayed when the selected value is 0=CD.
A value is displayed for 1=DVD or 2=vinyl.

Why is this?

@bobbingwide
Copy link
Owner Author

Why is this?

I would appear to be a bug in bw_return_field_select() in oik-fields/includes/oik-fields.inc.

This has some logic to deal with an empty array being passed as $value.
When it evaluates !empty( $val ) it incorrectly skips the value of '0'.

@bobbingwide bobbingwide transferred this issue from bobbingwide/oik-tunes Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant