-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode for the GUIs ? #47
Comments
Hey, glad you like the modules. Check out this older issue: I still don't really have the bandwidth to maintain a dark mode, but as on that issue you can find one here: https://github.com/NRG70/BogaudioModules It looks to be a few new modules out of date. Nothing stopping you from updating it, or making a new one, or getting a community project together to do it. |
Hi Matt and Stephan, Anyway, Stephan feel free to update, add to the repository in my account. |
Github doesn't automagically pull in the changes...instead you merge my upstream changes into your fork, and the push up the merged code. Here are their instructions: |
am i to understand that i need to use some software here on my computer, to maintain a fork? i need to think of a more easier method for all this. |
@NRG70 I would like to have a dark version fork with already compiled modules. |
@smok-e I haven't compiled or build anything. I simply forked from a certain older version from Matt. And edited the svg files. |
This is where you can find my edit: |
these have been updated: Rack V1 Rack 0.6.2c |
@mdemanett I was wondering for the next release of your plugin, would it be possible for you to add my dark theme to your styles.hpp so that it can be a switchable choice in the context menu. Cheers, |
Hey Latif, sounds good, though there are more modules coming still...I'll ping you when the release is up. Looks like maybe official dark mode support will come with rack v2...I'll probably wait and see how that goes and make dark mode part of the plugin then. How do you generate the dark panels anyway? Is it just a color invert? |
No, i edit all the elements that you designed, and change their color manually. One of the contributors at the forum made the dark style for Surge plugin for example by editing the style. Good thinking to wait and see which method Andrew will use for the dark mode. |
Hi Matt, Could it be possible for you to reconsider making dark theme part of the already existing Bogaudio plugin, I can ask a forum user who has helped out with the Surge Rack theming, to see if he wants to help out? edit: |
Hey Latif, it is actually finally on my radar to do this soon, at least to get a central stylesheet you all can edit. But probably also with an official dark mode. |
DARK MODE is finally here! Or at least ready to test. Installable test builds are here. There are actually two new skins; "Dark" is more classic: "Dark (low-contrast)" is less stark; @Eurikon this is basically your design, or at least that's what I was going for: Each module has a "Skin" context menu, which setting overrides the default. The default is "Light", which should look mostly like it always has. You can set the default skin: create a file named
You can change "dark" to "lowcontrast" as well. Feedback is welcome. (I already noticed, taking these screenshots, that the screws are positioned over the module name on some modules; will fix.) |
Hi Matt, I had a little test drive with the new dark modes, well done !!! |
Matt!! Thank you so much for making this happen :D Editing the json file works like a treat, and also makes the thumbnails in the browser show up in the chosen color, love it! Might need some inspection, i will let you know if i find anything. Thanks again for making this part of your plugin, well done! |
Here's an updated release: v1.1.33-test2 I fixed the S&H labels (good catch, thanks!!) and screw positions. Also, you'll need to rename I'll probably let this sit a couple days, to see what other problems turn up, and then release next week. |
the updated version is fine here, Is there any chance that the "default json" (Bogaudio.json) file can be created via the right click menue, as the plugins from Count Modula and Geodesics do? |
I was also wondering why this was not the case, as also Submarine and Impromptu has this like that. |
I took a close look at all module sin low-contrast theme, all looks fine to me. on a side note, and can you describe a use case / purpose for : Assign ? |
Another DARK MODE build here...as suggested I added menu items to set the default. Modules using the default skin should update immediately. Sometimes the module browser won't update, because it has its own caching...if you scroll far enough, then back, it will update. Thank you guys for the testing and feedback!! |
Is it necessary to allow theming on a per module basis? If you would simplify it to 3 choices for the whole plugin: light / dark /lowcontrast But of course that is just my opinion. |
Lindenberg does this so does Impromtu and Geodesics and Stoermelder. And to be honest I like to have that option. |
Ah ok, wasn’t aware those other plugins do that! |
The dark modes are fabulous, Matt. I like the low contrast in particular. Here is a couple of notes I made when checking it out:
Would you by any chance consider an additional dark/low contrast mode where the background of the ports is darkish too? It's very clear and usable right now, at the same time it looks a bit like leftovers from the light mode, if you know what I mean. Anyway, I think the new modes are great as they are, so thanks for that. |
It's an expander, when placed to the right of PGMR , does it work ? PEQ14 and LVCF 👍 |
It does. Thanks for pointing it out. |
@mdemanett I hear you. Sometimes stuff just doesn't work and form should follow function anyway IMHO. Great update. |
For future reference: |
Matt, are you going to announce this yourself at the forum? |
Nah, go ahead. Might mention it's "coming soon" since it'll probably take a couple days for it to get built and uploaded to the library... |
So it's live on the library, and announced on the forum. Thanks again y'all for helping make it happen! |
First I want to thank you for your great modules, I use them in every project I do in VCV.
my question:
Would it be possible that you add a dark mode to the interface of your fantastic modules? (Like the Geodesics e.g.)
I did a dark version for the mixers, which I use only on my private pc,
and I like this very much. (see the attached picture)
I also know there are some visually impaired users, which have problems with the light versions.
These would benefit from the dark GUIs.
I understand, that changing the GUI is a lot of work, but I think if you post a request in the VCV forum for some help,

there will be some folks that would support you ;-)
I can send you the svg's, if you want them.
The text was updated successfully, but these errors were encountered: