Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async validation #92

Open
SeverinAlexB opened this issue Mar 2, 2023 · 5 comments
Open

Async validation #92

SeverinAlexB opened this issue Mar 2, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@SeverinAlexB
Copy link

SeverinAlexB commented Mar 2, 2023

Is your feature request related to a problem? Please describe.
I ask the user for an account id. I like to validate this id by checking it against the db which I can't do sync.

Describe the solution you'd like
Make validate compatible with async.

Describe alternatives you've considered
Currently I load all the accounts before the prompt so I can validate the id sync. This doesn't scale though.

Additional context
That's it :)

@SeverinAlexB SeverinAlexB added the enhancement New feature or request label Mar 2, 2023
@ulken
Copy link
Collaborator

ulken commented Mar 2, 2023

Sounds reasonable. I'll have a looksy later.

@ulken ulken mentioned this issue Mar 2, 2023
@ulken
Copy link
Collaborator

ulken commented Mar 5, 2023

Follow-up to keep you in the loop: I started looking into this, but quickly realized we need to provide feedback to the user while waiting.

Not entirely obvious how that would fit into the current implementation flow. Asked for input, but haven't gotten any, yet.

@SeverinAlexB
Copy link
Author

Thx. I see your point. It is already worth having it without a spinner IMO. Most validation flows should be quick (db calls are in the ms). But I understand in case you want to have it perfect.

@ulken
Copy link
Collaborator

ulken commented Mar 6, 2023

Progress has been made. Have some rough edges to smooth out.

@jycouet
Copy link

jycouet commented Aug 4, 2023

How/where could we enjoy this progress? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Needs triage
Development

No branches or pull requests

3 participants