Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6 support #503

Closed
3 of 4 tasks
lcreid opened this issue Jan 19, 2019 · 4 comments
Closed
3 of 4 tasks

Rails 6 support #503

lcreid opened this issue Jan 19, 2019 · 4 comments

Comments

@lcreid
Copy link
Contributor

lcreid commented Jan 19, 2019

Ensure that bootstrap_form will work with Rails 6.

  • Check if the TravisCI pipeline is already testing Rails edge.
  • Add the next version of Rails to the TravisCI pipeline if it's not already there.
  • Fix any errors found.
  • Bonus marks: Enhance the build pipeline so we're always testing the next version, allowing certain errors, but preventing people from adding features to the current version that won't work in the next version.

If you want to work on this, assign the issue to yourself. You can do one or more items on the checklist -- no need to do them all. If you're not actively working on this issue, please unassign the issue so others can work on it.

If you find a specific issue where bootstrap_form is incompatible with Rails 6, please create an issue for it, and refer to this issue. Thanks in advance!

@nevware
Copy link

nevware commented Jan 25, 2019

it appears that Rails 6 includes the Trix editor as part of Action Text, and this doesn't work with bootstrap_form. May require update to documentation, but following the instructions causes an unselectable box on the form.

@lcreid
Copy link
Contributor Author

lcreid commented Jan 25, 2019

@nevware Thanks for reporting this! Would you mind creating a separate issue for it? It's easy to manage the work if we have a separate issue for each broken bit that we find. Thanks again for taking the time to give feedback.

@lcreid lcreid modified the milestone: 4.0.0 Jan 25, 2019
@lcreid lcreid self-assigned this Jan 25, 2019
@nevware
Copy link

nevware commented Jan 25, 2019

Done: #508

@lcreid
Copy link
Contributor Author

lcreid commented Sep 22, 2019

Version 4.3.0 has been deemed the official Rails 6.0.0 version. There is at least one reported issue with the rich text area support still (#540).

@lcreid lcreid closed this as completed Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants