skip_album is ignored

[mslookup]

System:

• OS: Synology DSM
• Version 7.2.2

Describe the bug
When setting photo_album="all albums" and skip_album="All Photos,Time-lapse,Videos,Slo-mo,Bursts,Favorites,Panoramas,Screenshots,Live,Recently Deleted,Hidden", skip_album gets ignored.

Expected behaviour
I expect the container to download all albums but the ones listed in "skip_album".

Actual behaviour
I still see all my photos getting downloaded to the "All Photos" album folder on disk, regardless whether I have excluded it in config or not.

Debug log file
2025-01-26 19:14:58 INFO Initialising container...
2025-01-26 19:14:59 INFO - Checking configuration file permissions
2025-01-26 19:14:59 INFO - Create/update configuration file: /config/icloudpd.conf
2025-01-26 19:15:00 INFO - Checking /config/icloudpd.conf for errors
2025-01-26 19:15:00 INFO | Delete accompanying files (.JPG/.HEIC.MOV)
2025-01-26 19:15:00 WARNING ! This feature deletes files from your local disk. Please use with caution. I am not responsible for any data loss
2025-01-26 19:15:00 WARNING ! This feature cannot be used if the 'folder_structure' variable is set to 'none' and also, 'set_exif_datetime' must be 'false'
2025-01-26 19:15:00 WARNING ! These two settings will increase the chances of de-duplication happening, which could result in the wrong files being removed
2025-01-26 19:15:00 WARNING Non-fatal configuration options detected. Continuing in 2 minutes...
2025-01-26 19:17:00 INFO - Checking user:group account: manfred:users
2025-01-26 19:17:00 INFO - Set owner and group on config directory: /config
2025-01-26 19:17:00 INFO - Set owner and group on icloudpd temp directory: /tmp/icloudpd
2025-01-26 19:17:00 INFO - Setting owner, group and permissions on: /home/manfred/iCloud
2025-01-26 19:17:00 DEBUG | Set owner
2025-01-26 19:17:00 DEBUG | Set group
2025-01-26 19:17:00 DEBUG | Set 750 permissions on directories
2025-01-26 19:17:00 DEBUG | Set 640 permissions on files
2025-01-26 19:17:00 INFO - Checking directories are writable by user: manfred
2025-01-26 19:17:00 INFO - Checking icloud.com is accessible
2025-01-26 19:17:01 INFO - Checking Telegram bot initialised
2025-01-26 19:17:08 INFO - Checking for updates: Current version is up to date
2025-01-26 19:17:08 INFO Initialisation complete
2025-01-26 19:17:08 INFO ***** boredazfcuk/icloudpd container v1.0.1179_25-01-2025 started *****
2025-01-26 19:17:08 INFO ***** For support, please go here: https://github.com/boredazfcuk/docker-icloudpd *****
2025-01-26 19:17:08 INFO Alpine Linux 3.21.2
2025-01-26 19:17:08 INFO Python version: 3.12.8
2025-01-26 19:17:08 INFO icloud-photos-downloader version: 1.26.1
2025-01-26 19:17:08 INFO Loading configuration from: /config/icloudpd.conf
2025-01-26 19:17:08 DEBUG Running user id: 0
2025-01-26 19:17:08 DEBUG Running group id: 0
2025-01-26 19:17:08 DEBUG Local user: ma********:1027
2025-01-26 19:17:08 DEBUG Local group: us********:100
2025-01-26 19:17:08 DEBUG Force GID: 100
2025-01-26 19:17:08 DEBUG LAN IP Address: 172.17.0.4
2025-01-26 19:17:08 DEBUG Default gateway: 172.17.0.1
2025-01-26 19:17:08 DEBUG DNS server: 192.168.240.1
2025-01-26 19:17:08 DEBUG IP address for icloud.com: 17.253.144.10
2025-01-26 19:17:08 INFO Debug logging: Enabled
2025-01-26 19:17:08 INFO Apple ID: mar@g.de
2025-01-26 19:17:08 INFO Cookie path: /config/mrgde
2025-01-26 19:17:08 INFO Cookie expiry notification period: 7
2025-01-26 19:17:08 INFO Download destination directory: /home/manfred/iCloud
2025-01-26 19:17:08 INFO Folder structure: {:%Y/%m}
2025-01-26 19:17:08 DEBUG Directory permissions: 750
2025-01-26 19:17:08 DEBUG File permissions: 640
2025-01-26 19:17:08 INFO Keep Unicode: false
2025-01-26 19:17:08 INFO Live Photo MOV Filename Policy: suffix
2025-01-26 19:17:08 INFO File Match Policy: name-size-dedup-with-suffix
2025-01-26 19:17:08 INFO Synchronisation interval: 86400
2025-01-26 19:17:08 INFO Synchronisation delay (minutes): 0
2025-01-26 19:17:08 INFO Set EXIF date/time: false
2025-01-26 19:17:08 INFO Auto delete: true
2025-01-26 19:17:08 INFO Delete after download: false
2025-01-26 19:17:08 INFO Delete empty directories: true
2025-01-26 19:17:08 INFO Photo size: original,adjusted
2025-01-26 19:17:08 INFO Align RAW: as-is
2025-01-26 19:17:08 INFO Single pass mode: false
2025-01-26 19:17:08 INFO Skip download check: false
2025-01-26 19:17:08 INFO Skip live photos: false
2025-01-26 19:17:08 INFO Number of most recently added photos to download: Download All Photos
2025-01-26 19:17:08 INFO Downloading photos from album(s): all albums
2025-01-26 19:17:08 INFO Stop downloading when prexisiting files count is: Download All Photos
2025-01-26 19:17:08 INFO Live photo size: original
2025-01-26 19:17:08 INFO Skip videos: false
2025-01-26 19:17:08 INFO Convert HEIC to JPEG: false
2025-01-26 19:17:08 INFO Delete accompanying files (.JPG/.HEIC.MOV)
2025-01-26 19:17:08 INFO Telegram notifications enabled
2025-01-26 19:17:08 DEBUG Notification title: boredazfcuk/iCloudPD
2025-01-26 19:17:08 DEBUG Telegram token: 52BM
2025-01-26 19:17:08 DEBUG Telegram chat id: 2400
2025-01-26 19:17:08 DEBUG Telegram polling: true
2025-01-26 19:17:08 DEBUG Telegram uses HTTP: false
2025-01-26 19:17:08 DEBUG Telegram base URL: https://api.telegram.org/bot52********BM
2025-01-26 19:17:08 DEBUG Telegram notification URL: https://api.telegram.org/bot52********BM/sendMessage
2025-01-26 19:17:08 DEBUG Checking api.telegram.org for updates
2025-01-26 19:17:08 INFO Latest update id: 0
2025-01-26 19:17:08 DEBUG Telegram silent file notifications: false
2025-01-26 19:17:08 DEBUG Startup notification: Enabled
2025-01-26 19:17:08 INFO Sending Telegram startup notification
2025-01-26 19:17:08 DEBUG Telegram startup notification sent successfully
2025-01-26 19:17:08 DEBUG Download notifications: Disabled
2025-01-26 19:17:08 DEBUG Delete notifications: Disabled
2025-01-26 19:17:08 INFO Downloading from: icloud.com
2025-01-26 19:17:08 DEBUG User agent impersonation for curl: Disabled
2025-01-26 19:17:08 INFO Authentication domain: com
2025-01-26 19:17:08 DEBUG Nextcloud upload: Disabled
2025-01-26 19:17:08 DEBUG Ignore Synology extended attribute directories: Disabled
2025-01-26 19:17:08 DEBUG Activated Python virtual environment for icloudpd
2025-01-26 19:17:08 DEBUG Configure password
2025-01-26 19:17:08 DEBUG Using password stored in keyring file: /config/python_keyring/keyring_pass.cfg
2025-01-26 19:17:08 INFO Check download directory mounted correctly...
2025-01-26 19:17:08 INFO Failsafe file /home/manfred/iCloud/.mounted exists, continuing
2025-01-26 19:17:08 DEBUG Adding photo size original to size types
2025-01-26 19:17:08 DEBUG Adding photo size adjusted to size types
2025-01-26 19:17:08 INFO Keyring file exists, continuing
2025-01-26 19:17:08 INFO Sync user: manfred
2025-01-26 19:17:08 INFO Synchronisation starting at 19:17:08
2025-01-26 19:17:08 INFO Keyring file exists, continuing
2025-01-26 19:17:08 DEBUG Check MFA Cookie
2025-01-26 19:17:08 DEBUG Multifactor authentication cookie exists
2025-01-26 19:17:08 DEBUG Valid multifactor authentication cookie found. Days until expiration: 26
2025-01-26 19:17:08 INFO Check download directory mounted correctly...
2025-01-26 19:17:08 INFO Failsafe file /home/manfred/iCloud/.mounted exists, continuing
2025-01-26 19:17:08 INFO Check for new files using password stored in keyring file
2025-01-26 19:17:08 INFO Generating list of files in iCloud. This may take a long time if you have a large photo collection. Please be patient. Nothing is being downloaded at this time
2025-01-26 19:17:08 DEBUG Launch command: /opt/icloudpd/bin/icloudpd --directory /home/manfred/iCloud --cookie-directory /config --username manfred[email protected] --domain com --folder-structure {:%Y/%m} --only-print-filenames
/home/manfred/iCloud/2025/01/IMG_1331.HEIC
/home/manfred/iCloud/2025/01/IMG_1330.HEIC
/home/manfred/iCloud/2025/01/IMG_1326.HEIC
/home/manfred/iCloud/2025/01/IMG_1325.HEIC
/home/manfred/iCloud/2025/01/IMG_1324.HEIC
/home/manfred/iCloud/2025/01/IMG_1322.HEIC
/home/manfred/iCloud/2025/01/IMG_1321.HEIC
2025-01-26 19:35:00 INFO Check successful
2025-01-26 19:35:00 INFO New files detected: 7
2025-01-26 19:35:00 DEBUG Starting download of new files for user: manfred
2025-01-26 19:35:00 DEBUG Downloading new files using password stored in keyring file...
2025-01-26 19:35:00 DEBUG Starting Photo Album download
2025-01-26 19:35:08 DEBUG Buildling list of albums to download...
2025-01-26 19:35:08 DEBUG - All Photos
2025-01-26 19:35:08 DEBUG - Time-lapse
2025-01-26 19:35:08 DEBUG - Videos
2025-01-26 19:35:08 DEBUG - Slo-mo
2025-01-26 19:35:08 DEBUG - Bursts
2025-01-26 19:35:08 DEBUG - Favorites
2025-01-26 19:35:08 DEBUG - Panoramas
2025-01-26 19:35:08 DEBUG - Screenshots
2025-01-26 19:35:08 DEBUG - Live
2025-01-26 19:35:08 DEBUG - Recently Deleted
2025-01-26 19:35:08 DEBUG - Hidden
2025-01-26 19:35:08 DEBUG - eBay
2025-01-26 19:35:08 DEBUG Starting albums download...
2025-01-26 19:35:08 INFO Downloading album: All Photos
2025-01-26 19:35:08 DEBUG iCloudPD launch command: /opt/icloudpd/bin/icloudpd --directory /home/manfred/iCloud --cookie-directory /config --domain com --username manfred[email protected] --no-progress-bar --size original --size adjusted --auto-delete --log-level debug --folder-structure "All Photos" --album "All Photos" 2>/tmp/icloudpd/icloudpd_download_error
2025-01-26 19:35:09 DEBUG Authenticating...
2025-01-26 19:35:14 DEBUG Looking up all photos and videos from album All Photos...
2025-01-26 19:35:14 INFO Downloading 36721 original,adjusted photos and videos to /home/manfred/iCloud ...
2025-01-26 19:35:17 DEBUG /home/manfred/iCloud/All Photos/IMG_1334.PNG already exists
2025-01-26 19:35:17 DEBUG /home/manfred/iCloud/All Photos/1FB70D3D-259A-4EB9-891F-16F9872B5FB4.JPG already exists
2025-01-26 19:35:17 DEBUG /home/manfred/iCloud/All Photos/IMG_1332.PNG already exists
2025-01-26 19:35:17 DEBUG /home/manfred/iCloud/All Photos/IMG_1331.HEIC already exists
2025-01-26 19:35:17 DEBUG /home/manfred/iCloud/All Photos/IMG_1331-adjusted.HEIC already exists
2025-01-26 19:35:17 DEBUG /home/manfred/iCloud/All Photos/IMG_1330.HEIC already exists
2025-01-26 19:35:17 DEBUG /home/manfred/iCloud/All Photos/IMG_1330-adjusted.HEIC already exists
2025-01-26 19:35:17 DEBUG /home/manfred/iCloud/All Photos/IMG_1329.PNG already exists
2025-01-26 19:35:17 DEBUG /home/manfred/iCloud/All Photos/IMG_1326.HEIC already exists
2025-01-26 19:35:17 DEBUG /home/manfred/iCloud/All Photos/IMG_1326-adjusted.HEIC already exists
2025-01-26 19:35:17 DEBUG /home/manfred/iCloud/All Photos/IMG_1325.HEIC already exists
2025-01-26 19:35:17 DEBUG /home/manfred/iCloud/All Photos/IMG_1325-adjusted.HEIC already exists
2025-01-26 19:35:17 DEBUG /home/manfred/iCloud/All Photos/IMG_1324.HEIC already exists
2025-01-26 19:35:17 DEBUG /home/manfred/iCloud/All Photos/IMG_1324-adjusted.HEIC already exists
2025-01-26 19:35:17 DEBUG /home/manfred/iCloud/All Photos/IMG_1322.HEIC already exists
2025-01-26 19:35:17 DEBUG /home/manfred/iCloud/All Photos/IMG_1322-adjusted.HEIC already exists
[...]

icloudpd.conf
agentid=
albums_with_dates=false
align_raw=as-is
apple_id=manfred[email protected]
auth_china=false
authentication_type=MFA
auto_delete=true
bark_device_key=
bark_server=
content_source_url=
convert_heic_to_jpeg=false
debug_logging=true
delete_accompanying=true
delete_after_download=false
delete_empty_directories=true
delete_notifications=false
dingtalk_token=
directory_permissions=750
discord_id=
discord_token=
download_notifications=false
download_path=/home/manfred/iCloud
fake_user_agent=false
file_match_policy=name-size-dedup-with-suffix
file_permissions=640
folder_structure={:%Y/%m}
force_gid=100
gotify_app_token=
gotify_https=
gotify_server_url=
group=users
group_id=100
icloud_china=false
iyuu_token=
jpeg_path=
jpeg_quality=90
keep_icloud_recent_days=
keep_icloud_recent_only=false
keep_unicode=false
libraries_with_dates=false
live_photo_mov_filename_policy=suffix
live_photo_size=original
media_id_delete=
media_id_download=
media_id_expiration=
media_id_startup=
media_id_warning=
msmtp_args=--tls-starttls=off
msmtp_from=
msmtp_host=
msmtp_pass=
msmtp_port=
msmtp_tls=on
msmtp_to=
msmtp_user=
name=
nextcloud_delete=false
nextcloud_password=
nextcloud_upload=false
nextcloud_url=
nextcloud_username=
notification_days=7
notification_type=Telegram
photo_album="all albums"
photo_library=
photo_size=original,adjusted
prowl_api_key=
pushover_sound=
pushover_token=
pushover_user=
recent_only=
set_exif_datetime=false
sideways_copy_videos=false
sideways_copy_videos_mode=copy
single_pass=false
skip_album="All Photos,Time-lapse,Videos,Slo-mo,Bursts,Favorites,Panoramas,Screenshots,Live,Recently Deleted,Hidden"
skip_check=false
skip_download=false
skip_library=
skip_live_photos=false
skip_videos=false
startup_notification=true
synchronisation_delay=0
synchronisation_interval=86400
synology_ignore_path=false
synology_photos_app_fix=false
telegram_chat_id=2***0
telegram_http=false
telegram_polling=true
telegram_server=
telegram_silent_file_notifications=
telegram_token=52**********************iBM
touser=
trigger_nextlcoudcli_synchronisation=
until_found=
user=manfred
user_id=1027
video_path=
webhook_https=false
webhook_id=
webhook_insecure=false
webhook_path=/api/webhook/
webhook_port=8123
webhook_server=
wecom_id=
wecom_proxy=
wecom_secret=

Maybe it is related to:

23/11/2024

• Well, seems like remote auth was royally fucked with the switch from ash to bash due to the regex matching. Think it's fixed. Pretty sure there were PRs surrounding the photo_album and photo_lirary features that used the same regex based matches. they could be broke, but it's late, so I'm going to bed. I'm also a bit drunk so I'll probably forget to check if its broken tomorrow.

Thank you! :-)

[boredazfcuk]

skip_album is singular, so it's attempting to skip an album named:
"All Photos,Time-lapse,Videos,Slo-mo,Bursts,Favorites,Panoramas,Screenshots,Live,Recently Deleted,Hidden"

Well, seems like remote auth was royally fucked with the switch from ash to bash due to the regex matching. Think it's fixed. Pretty sure there were PRs surrounding the photo_album and photo_lirary features that used the same regex based matches. they could be broke, but it's late, so I'm going to bed. I'm also a bit drunk so I'll probably forget to check if its broken tomorrow.

I actually reverted back to ash earlier this year as bash adds a bunch of bloat for little extra value.

I'll leave this open as I'll have a look at it some point further down the line when I get a bit of extra time. I guess I'm just going to need to loop through the list of albums and check them with the album name. I'm going to need to rename it to skip_albums and have some way of migrating people too. Needs a bit of time to get that coded in.