Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PoseFactor to JointFactor #283

Closed
varunagrawal opened this issue Sep 25, 2021 · 1 comment
Closed

Rename PoseFactor to JointFactor #283

varunagrawal opened this issue Sep 25, 2021 · 1 comment
Assignees
@varunagrawal @dellaert
Labels
refactor Refactoring of code to remove rot

Comments

@varunagrawal
Copy link
Collaborator

PoseFactor is not a very descriptive name for what the factor is doing. A better name would be JointFactor or JointConstraintFactor. I prefer JointFactor since it is easy to remember and encapsulates what the factor is all about.

Another design decision to consider with @dellaert.
@varunagrawal varunagrawal added the refactor Refactoring of code to remove rot label Sep 25, 2021
@varunagrawal
Copy link
Collaborator Author

PoseFactor is consistent with TwistFactor naming scheme, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varunagrawal varunagrawal

@dellaert dellaert

Labels
refactor Refactoring of code to remove rot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@varunagrawal @dellaert