Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicsGraph.h missing #include <boost/format.hpp> #336

Closed
arutkowski opened this issue Feb 19, 2022 · 4 comments
Closed

DynamicsGraph.h missing #include <boost/format.hpp> #336

arutkowski opened this issue Feb 19, 2022 · 4 comments
Assignees

Comments

@arutkowski
Copy link
Collaborator

Trying to build GTDynamics, I got the following error:

In file included from /home/adam/GTDynamics/gtdynamics/dynamics/DynamicsGraph.cpp:34:
/home/adam/GTDynamics/gtdynamics/utils/JsonSaver.h: In static member function ‘static std::string gtdynamics::JsonSaver::GetNoiseModel(const shared_ptr&)’:
/home/adam/GTDynamics/gtdynamics/utils/JsonSaver.h:262:22: error: ‘format’ is not a member of ‘boost’; did you mean ‘boost::timer::format’?
  262 |         ss << boost::format("isotropic dim=%1% sigma=%2%") %
      |    

Adding #include <boost/format.hpp> to DynamicsGraph.h seems to fix the issue.

@dellaert
Copy link
Member

Ah, yes - I have removed that include from Matrix.h in gtsam. Sorry!
Feel free to make a PR but that file should be in a cpp file where used if possible to avoid header bloat.

@dellaert
Copy link
Member

I went ahead and created #337 but now get in trouble building python wrapper. Confirm this works for you?

@varunagrawal
Copy link
Collaborator

Can confirm #337 works. @dellaert can you try rebuilding the project from scratch?

@dellaert
Copy link
Member

Removing build and starting from scratch worked. Probably because my build folder was rather old.
I'll close this issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants