Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triangulation support for SmartProjectionPoseFactor #102

Open
dellaert opened this issue Aug 8, 2019 · 1 comment
Open

Triangulation support for SmartProjectionPoseFactor #102

dellaert opened this issue Aug 8, 2019 · 1 comment
Labels
help wanted Need help and/or clarification

Comments

@dellaert
Copy link
Member

dellaert commented Aug 8, 2019

Feature

Someone (probably @chrisbeall-nuro back in the day) added smart triangulation capabilities to the SmartProjectionFactor. Is there a reason why this cannot also be integrated in the SmartProjectionPoseFactor and hence could be pushed to the base class?

Motivation

This would enable using smart factors with triangulation support when the camera calibration is fixed, and optionally a sensor offset is known.

Pitch

Push triangulation code into base class SmartFactorBase.

Additional context

There is an issue that in theory not all smart factors are about projections. Hence, it might need interposing an intermediate smart factor base class that is specialized to image projections and can benefit from triangulation.

@dellaert dellaert added the help wanted Need help and/or clarification label Aug 8, 2019
@dellaert
Copy link
Member Author

dellaert commented Aug 8, 2019

I found out by solving issue #101 that SmartProjectionFactor is already a base class of SmartProjectionPoseFactor, so it seems the functionality is already available. It's not clean, though, as it is strange to have a factor on two variables derive from a factor on one (other) variable. A common base class would be cleaner.

@varunagrawal varunagrawal modified the milestones: GTSAM 4.0.3, GTSAM 4.1 Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Need help and/or clarification
Projects
None yet
Development

No branches or pull requests

2 participants