Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where in the code is the hash of each part provided during an upload? #1830

Closed
jonbesga opened this issue Jan 8, 2019 · 2 comments
Closed
Labels
guidance Question that needs advice or information. question

Comments

@jonbesga
Copy link

jonbesga commented Jan 8, 2019

Hi!

According to #1699 and #845. Boto3 doesn't make an integrity check of multipart uploads but it does send an md5 hash for each part so S3 will complain is there's a mismatch. I'm trying to find the code that does that in the boto3 and s3transfer code but I can't find it.

Could anyone point me to the code that's managing this part?

Thanks

@kyleknap
Copy link
Contributor

kyleknap commented Jan 8, 2019

Yep. The md5's are calculated as a part of this handler registration which calls out to these functions to calculate the md5 of the request body and put it in the request header. Hope this helps!

@kyleknap kyleknap added question closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jan 8, 2019
@jonbesga
Copy link
Author

jonbesga commented Jan 9, 2019

Thanks! I missed looking into botocore

@jonbesga jonbesga closed this as completed Jan 9, 2019
@no-response no-response bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jan 9, 2019
@swetashre swetashre added the guidance Question that needs advice or information. label Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidance Question that needs advice or information. question
Projects
None yet
Development

No branches or pull requests

3 participants