New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: chrome examples should used string for version number #165

Closed

tavelli opened this issue Sep 26, 2016 · 1 comment

tavelli commented Sep 26, 2016

in the README chrome versions are using a number type, but the library seems to expect a string, like shown in the IE examples.

so when something like example is run:

bowser.check({chrome: 45}, window.navigator.userAgent); // true

browser throws error "Uncaught TypeError: version.split is not a function".

When chrome:"45" is used, everything seems to work fine.

lancedikson closed this as completed in

8b92707

Collaborator

lancedikson commented Oct 31, 2016

Thanks, @tavelli. I fixed the docs and added throwing an understandable error in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment