-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package ClusterRunner using Docker container #328
Comments
Hi, @yamaszone. Thanks for bringing this up. We have actually been thinking about converting our distribution from cx_Freeze to a Dockerfile/container. It would be awesome to see a PR for this. :) |
Instead of downloading the binary into the container, what do you think of just starting from a minimal distro with Python 3.4 and running ClusterRunner from source? In that situation, the |
@josephharrington I was thinking the same but was also considering impact of binary vs. source on Docker image size. We may have two image flavors |
I'd be surprised if the binary version was much different in size than Python+ClusterRunner source. I think the way that we create the binary (cx_Freeze) basically packages the Python interpreter and the source together. But you never know. :) I don't think we have a specific distro preference. We use CentOS for some stuff internally, but I'm sure Ubuntu or something would work fine for this as well. @tjlee0909 @gcurtis @nadeemahmad please chime in if you guys have any opinions on this. |
@josephharrington From my quick experimentation, it looks like we will have to maintain two flavors From details on the build, you can see |
Interesting! That's great that you were able to put those together. I think that As for I'm interested in digging a bit deeper to see what we can cut to get the image as small as possible. Maybe some other alternatives would be to remove I'll chat with the rest of our team about this later this week, but feel free to submit a PR in the meantime with whatever you find most useful. |
@josephharrington You almost nailed it! ;)
[1st Iteration] will allow me to be comfortable with the behaviors of CR on our test suites and will help me verify the build for [2nd Iteration] later. For [3rd Iteration], I need to deep dive into the codebase but definitely you guys can be ahead with this. I saw nice user guide docs but I am yet to come across any detailed technical docs/specs (covering system architecture, class diagrams, sequence diagrams, module organizations/dependencies, etc.). @josephharrington Any pointers? BTW, I have RSVPed for tomorrow's meetup at your HQ and looking forward to meeting you guys! |
@yamaszone Your plan sounds great. I can give you some tips on the 3rd step you mentioned whenever we get there. Unfortunately we don't have any good tech docs yet; that's still something we need to put together. I do think we need a good tech overview for contributors though -- hopefully we can do something around that soon. |
Feature proposal for the following:
mkdir -p ~/.clusterrunner/dist && cd ~/.clusterrunner && curl -L https://cloud.box.com/shared/static/2pl4pi6ykvrbb9d06t4m.tgz > clusterrunner.tgz && tar -zxvf clusterrunner.tgz -C ./dist && cp ./dist/conf/default_clusterrunner.conf clusterrunner.conf && chmod 600 clusterrunner.conf
using a minimal distro in a Docker containerThe text was updated successfully, but these errors were encountered: