Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simplify base urls usage #815

Merged
merged 15 commits into from
Apr 7, 2022
Merged

fix: simplify base urls usage #815

merged 15 commits into from
Apr 7, 2022

Conversation

mwwoda
Copy link
Contributor

@mwwoda mwwoda commented Apr 5, 2022

No description provided.

@mwwoda mwwoda changed the title feat: expose revoke and authorize urls in BoxConfigBuilder feat: expose revoke and authorize urls in BoxConfigBuilder Apr 5, 2022
antusus
antusus reviewed Apr 6, 2022
View reviewed changes
Copy link
Contributor

@antusus antusus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not yet sure why we want to separate authorisation and revoke URL from base URL. If a customer has his own domain or subdomain within box would they change just base urls for API calls and leave the authorisation URLs not changed?

Box.V2/Config/BoxConfigBuilder.cs Outdated Show resolved Hide resolved
@mwwoda mwwoda changed the title feat: expose revoke and authorize urls in BoxConfigBuilder fix: refactor base urls Apr 6, 2022
@mwwoda mwwoda changed the title fix: refactor base urls fix: refactor base urls Apr 6, 2022
@mwwoda mwwoda changed the title fix: refactor base urls fix: simplify base urls usage Apr 6, 2022
antusus
antusus previously approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@antusus antusus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

antusus
antusus approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@antusus antusus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@antusus antusus merged commit f8e7344 into main Apr 7, 2022
@antusus antusus deleted the sdk-2099-urls-updates branch April 7, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antusus antusus antusus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwwoda @antusus