feat: Add support for modifiable retention policies & enable deleting retention policy assignment #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwwoda
reviewed
Sep 12, 2022
...2.Test.Integration/Configuration/Commands/DisposableCommands/CreateRetentionPolicyCommand.cs
Show resolved
Hide resolved
Box.V2/Models/BoxRetentionPolicy.cs
Outdated
Comment on lines
91
to
96
|
|
||
| /// <summary> | ||
| /// The type of retention policy. Value is one of modifiable or non-modifiable. | ||
| /// </summary> | ||
| [JsonProperty(PropertyName = FieldRetentionType)] | ||
| public virtual string RetentionType { get; set; } |
There was a problem hiding this comment.
I think that we can use enum there if we have only 2 possible values.
mwwoda
reviewed
Sep 12, 2022
Box.V2.Test.Integration/BoxRetentionPolicyManagerIntegrationTest.cs
Outdated
Show resolved
Hide resolved
congminh1254
force-pushed
the
sdk-2023-retention-policy-assignment
branch
from
69eb9f7 to
afdecd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: SDK-2023