-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks order #64
Comments
Organizationally, I can see that. But, I want to make sure, is there a problem you're also looking to solve? |
No problem to solve as such. Just thinking as a customer or as someone that could use this tool for their customers and when generating the report document I feel it would be better presented with the infrastructure first. It's sort of the home to the rest in a way. Just a thought mind. |
Okay good. I like it too. It will take a bit of work. I'm going to leave this open for now. |
Thanks. If it's ok with you I could knock up a draft of the order and maybe move some of the checks around for your review. |
That would be great and really appreciated. |
Awesome. I will start working on it tomorrow. |
Here is the current order:
Here is the proposed order. I have also changed some names like tag is now labels, as it makes more sense with Azure.
Let me know your thoughts. |
@PixelRobots - Sorry about this, this went stale. If you want to pursue this, we can re-kindle this issue. Just let us know, otherwise, we can close it. |
Hey, yeah happy to pursue it again. Love the tool and happy to give it some love. |
@PixelRobots - I'm making the change to the doc. Do you want to try re-arranging the check order in the code? |
Also, @PixelRobots could we keep the change scoped to only the re-ordering of sections? So, excluding the re-classification of some of the checks. For example, some checks like We will need to experiment with having different versions of the document that we can keep in sync with release versions of the companion health check tool. |
I think CSP should be the first check then DEV. It makes sense to me to get the cluster right before the apps.
Thoughts?
The text was updated successfully, but these errors were encountered: