Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit SSDataGrid data validation #12

Open
bpangburn opened this issue Dec 11, 2020 · 2 comments
Open

Audit SSDataGrid data validation #12

bpangburn opened this issue Dec 11, 2020 · 2 comments

Comments

@bpangburn
Copy link
Owner

Review/modify SSDataGrid data validation to insure it's aligned with data validation conventions in RowSetOps and SSCommon.

@bpangburn
Copy link
Owner Author

Looks like SSDataGrid does some one-off rendering/masks for dates (e.g., protected class DateEditor) and handles some casting (e.g,. getCellEditorValue()). Also making use of java.sql.Types vs. java.sql.JDBCType (#14).

@errael
Copy link
Contributor

errael commented Feb 23, 2023

How grid relates to SS-4.x is something I'm not in a good position to judge.

This issue's original post is about data validation conventions. My understanding is that a big part of 4.x is SSComponent/SSCommon/SyncManager. Should these relate to SSDataGrid as well as the colum oriented components?

SSComponentInterface

SSComponentInterface seems to be column oriented,
Grid doesn't use this (grid isn't column oriented).

Should there be an interface for things that are row oriented?
Conceptually, how about

  • SSDataGrid implements SSRowComponent
  • SSCheckBox implements SSColumnComponent
  • SSRowComponent,SSColumnComponent both implement SSComponent

Or maybe just two interfaces,

  • SSColumnComponent extends SSRowComponent

SSDataGrid working with Navigator widget.

SSDataGridHandler - SSDBNav

Totally separate interfaces, but seem to be about the same things; they should be unified.

Maybe there are two interfaces and one implements the other?

Names don't seem particularly suggestive of what is going on.
There's also "SSDataGridAdapter implements SSDataGridHandler"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants