Do not adjust lane parent to participant #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With diagram-js@5 we've introduced the CreateBehavior that ensures elements are not created on top of lanes but always on top of the actual participant. Unfortunately we forgot about the fact that lanes are created once in a while, too. This commit accounts for this fact and ensures we do not adjust the parent of to-be-created lanes. (A test cases for splitting nested lanes did not exist until now). Closes #1254 Closes #1253
|
@pinussilvestrus Maybe you can take over reviewing this one? |
|
@pinussilvestrus and I agreed that I'll review this PR. 👍 |
This was referenced Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1254
Closes #1253