[CLOSED] CSS Url Hinting support

[core-ai-bot]

Issue by redmunds
Friday Apr 19, 2013 at 02:18 GMT
Originally opened as adobe/brackets#3485

---

This implements url hinting for CSS:

1. Moves url hinting code from HTMLCodeHints extension to new UrlCodeHints extension
2. Adds support for CSS

In CSS, url hinting is supported for url() in any property value or in@import.

---

redmunds included the following code: https://github.com/adobe/brackets/pull/3485/commits

[core-ai-bot]

Comment by redmunds
Wednesday May 01, 2013 at 17:24 GMT

---

Note: hold off reviewing for now as I'm working on it this week. If you really want to try it out, it requires a change to Code Mirror in this pull request: codemirror/codemirror5#1487.

[core-ai-bot]

Comment by redmunds
Thursday May 02, 2013 at 14:57 GMT

---

I added support for quotes inside url(), and support url() in@import rule, so this is ready for review. I left the "REVIEW ONLY" label on because this still needs the Code Mirror fix (so do not merge into master, yet). Marijn merged the fix into CodeMirror, but we need to merge it into the Brackets repo.

UPDATE: the CodeMirror fix is now in Brackets master, so this is ready to merge.

[core-ai-bot]

Comment by njx
Friday May 10, 2013 at 01:57 GMT

---

@RaymondLim, would you mind reviewing this?

[core-ai-bot]

Comment by redmunds
Monday May 20, 2013 at 16:44 GMT

---

@RaymondLim I added Unit Tests.

[core-ai-bot]

Comment by redmunds
Sunday May 26, 2013 at 23:35 GMT

---

Fixes pushed for code review. Let me know when it's ready to merge and I can squash all the commits.

[core-ai-bot]

Comment by RaymondLim
Tuesday May 28, 2013 at 21:33 GMT

---

Done for second review.

[core-ai-bot]

Comment by redmunds
Wednesday May 29, 2013 at 04:15 GMT

---

Pushed more changes.

[core-ai-bot]

Comment by redmunds
Wednesday May 29, 2013 at 17:32 GMT

---

Pushed more JSDoc fixed

[core-ai-bot]

Comment by RaymondLim
Wednesday May 29, 2013 at 18:02 GMT

---

Looks good. Merging.