Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Mac only: Quick View popover may not appear after resizing window or going fullscreen #3351

Open
core-ai-bot opened this issue Aug 29, 2021 · 21 comments
Open

[CLOSED] Mac only: Quick View popover may not appear after resizing window or going fullscreen #3351

core-ai-bot opened this issue Aug 29, 2021 · 21 comments

Comments

@core-ai-bot
Copy link
Member

Issue by RaymondLim
Tuesday Apr 23, 2013 at 22:46 GMT
Originally opened as adobe/brackets#3570

  1. Open main.css from Getting Started project.
  2. Mouse over gradients and verify that you see a popover for each.
  3. Resize window width to half of the original width or even smaller OR go fullscreen.
  4. Mouse over those gradients again.

Result: No popover. If you still see popover, then resize the window to the original width and repeat step 3 and 4.

Workaround: Move the mouse to the top of the screen.
@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Tuesday Apr 23, 2013 at 22:49 GMT

@redmunds It seems your changes to assign $editorHolder.offset().left to a variable introduce this one.

It turns out to be intermittent issue on my mac only. I can't reproduce it on my win7, but on mac I can even reproduce it with older build without your changes.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Wednesday Apr 24, 2013 at 00:04 GMT

We just need to listen for resize event and hide preview on resize.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Wednesday Apr 24, 2013 at 00:07 GMT

Can you reproduce it? It's not hiding issue. It's not showing up after resizing sometimes, but not all the times.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Wednesday Apr 24, 2013 at 02:25 GMT

What I'm seeing is that popover is not dismissed when resizing. You can resize it so popover is still showing, but is off the screen so you can't see it. Mouse over won't show it because it's already showing. Mouse over something else and move mouse back, and popover will reposition on the screen.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Wednesday Apr 24, 2013 at 02:46 GMT

See if this branch fixes what you're seeing: adobe/brackets#3577

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Wednesday Apr 24, 2013 at 05:00 GMT

Nope, I still see the issue of not showing quick view. But your changes did hide the quick view.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Wednesday Apr 24, 2013 at 20:28 GMT

I backed out my fix because the mouseout handler now hides preview before you can start resizing.

I can't repro on Mac10.8.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Thursday Apr 25, 2013 at 15:23 GMT

@RaymondLim ,@peterflynn I just noticed that this was still assigned to me. Removing myself since I cannot reproduce this one.

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Thursday Apr 25, 2013 at 15:55 GMT

I can repro consistently by going into fullscreen mode. After entering fullscreen mode, all mouse over/move events are missing. In addition to quick view not working, you don't see a resize cursor, and tooltips don't appear.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Thursday Apr 25, 2013 at 16:16 GMT

I am getting quick view in full screen mode, but it's in the wrong place! It's showing up 300px or so above where the mouse is.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Thursday Apr 25, 2013 at 16:19 GMT

Very intermittant, though. Seems to have something to do with where last click/mouse position was. Use mouse-wheel to scroll up/down to see different things show up :)

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Thursday Apr 25, 2013 at 16:25 GMT

@redmunds I'm seeing the symptom that you're seeing only if I use two-fingers-click (and/or scroll) on an element that can be shown as Quick View.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Thursday Apr 25, 2013 at 16:28 GMT

@RaymondLim I'm using a mouse.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Thursday Apr 25, 2013 at 16:32 GMT

Tagging CEF label as this is not really an issue in Quick View, but in cef.

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Thursday Apr 25, 2013 at 19:10 GMT

Updated title and added workaround to description.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Apr 25, 2013 at 20:56 GMT

Is there a known CEF bug already filed?

@core-ai-bot
Copy link
Member Author

Comment by pthiess
Thursday May 02, 2013 at 20:25 GMT

Reviewed@RaymondLim - Raymond pleas see if there is an existing CEF bug or file one if not.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Thursday May 09, 2013 at 05:37 GMT

Just file a new issue in cef http://code.google.com/p/chromiumembedded/issues/detail?id=969&q=No%20mousemove%20or%20mouseover%20events%20after%20switching

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Monday Jun 17, 2013 at 17:11 GMT

This is fixed CEF3.1453.1255

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Wednesday Jun 19, 2013 at 17:52 GMT

FBNC to@RaymondLim

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Friday Jun 21, 2013 at 23:59 GMT

Fix confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot