Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Clean up tern web workers whenever we re-init the tern server, or close ... #3708

Open
core-ai-bot opened this issue Aug 29, 2021 · 2 comments
Open

[CLOSED] Clean up tern web workers whenever we re-init the tern server, or close ... #3708

core-ai-bot opened this issue Aug 29, 2021 · 2 comments

Comments

@core-ai-bot
Copy link
Member

Issue by eztierney
Friday May 24, 2013 at 01:14 GMT
Originally opened as adobe/brackets#3983

...a project.

If we don't call terminate on the worker, it appears that the worker, and all the memory it's using will never get collected. So when we were switching projects, we were leaving behind orphaned workers, resulting in a large memory leak.

To enable re-initing the web worker I had to change around the logic - now the worker sends a message when it is done being init'ed and the main thread waits for that message before it starts sending messages to the workers.

eztierney included the following code: https://github.com/adobe/brackets/pull/3983/commits
@core-ai-bot
Copy link
Member Author

Comment by dloverin
Friday May 24, 2013 at 10:44 GMT

done reviewing.

@core-ai-bot
Copy link
Member Author

Comment by julianasuh
Friday May 24, 2013 at 17:24 GMT

Open to@dloverin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot