Make it easier to customize the export filename when using ExportMixin #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but your two tests have the same name, so flake8 fails. Can you fix that? |
This makes it easier to configure the download filename as it avoids having to override the get_export_filename method.
federicobond
force-pushed
the
export-filename
branch
from
bb23853 to
317d086
Compare
|
Right, I hadn't noticed that. Fixed now. |
|
Thanks, @federicobond, merged |
jieter
added a commit
that referenced
this pull request
Oct 6, 2017
|
released 1.12.0 |
This was referenced Oct 10, 2017
|
👍 Thanks! |
This was referenced Oct 12, 2017
This was referenced Oct 30, 2017
This was referenced Nov 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added missing tests and documentation.