Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The config is reset after updating the app #173

Closed
baruchiro opened this issue Dec 25, 2020 · 1 comment · Fixed by #185
Closed

The config is reset after updating the app #173

baruchiro opened this issue Dec 25, 2020 · 1 comment · Fixed by #185
Assignees
@baruchiro
Labels
bug Something isn't working

Comments

@baruchiro
Copy link
Collaborator

I think after installing an app upgrade (by downloading a new artifact, on Windows), the config is reset.

Maybe it is the location we are saving the config. I think we need to save it in electron.app.getPath('userData')
@baruchiro baruchiro mentioned this issue Dec 28, 2020
Merged
@baruchiro
Copy link
Collaborator Author

Consider using global var as described in #172 (comment)

@baruchiro baruchiro self-assigned this Jan 4, 2021
@baruchiro baruchiro added the bug Something isn't working label Jan 10, 2021
@baruchiro baruchiro mentioned this issue Jan 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baruchiro baruchiro

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Save config in UserData path brafdlog/caspion
1 participant
@baruchiro