-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deps: add prettier config & adapt eslint config #497
Conversation
what is the motivation: https://www.youtube.com/watch?v=Cd-gBxzcsdA
Thank you! Even before it is accepted, I'm expecting you to test it is not conflicted with ESLint. Did you run it and run Also, I can't see how it helps. No one will change the whole source code. Instead, I'm asking you to add it with |
yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work!
I will test it locally and then I will merge it.
What will be your next task? Contact me
I see that the ci dont pass because of the node version what should we do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still a mismatch between prettier
and ESLint
.
When I'm running yarn prettier --write .
and then yarn lint
, I see multiple warnings like this:
⚠ http://eslint.org/docs/rules/object-curly-newline Expected a line break before this closing brace src\Store.test.tsx:3:56
I'm navigating to this file (src/Store.test.tsx:3:56
), formatting it with prettier
, and it shows me an ESLint
worning. I'm fixing the ESLint
warning, and formatting it again, and the warning cames back.
@baruchiro 26c4866 see this commit a think it the right approach |
I think the next step is to move to using Vite. |
🎉 This PR is included in version 1.13.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
what is the motivation:
https://www.youtube.com/watch?v=Cd-gBxzcsdA
if this or accepted we should add format to git hooks
add run yarn format on all project