Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This library assumes that all Action's will have a 'payload' attribute #31

Open
alexjlockwood opened this issue Mar 24, 2018 · 1 comment

Comments

@alexjlockwood
Copy link

alexjlockwood commented Mar 24, 2018

In earlier versions of ngrx, the Action interface had a payload attribute. This no longer seems to be the case:

https://github.com/ngrx/platform/blob/master/modules/store/src/models.ts#L1-L3

I am wondering if this library needs to be updated to account for this. For instance, in the source code it makes a check if (action.payload):

https://github.com/brandonroberts/ngrx-store-freeze/blob/master/src/index.ts#L19-L21

But what happens when the action uses a different name other than payload?

@maikdiepenbroek
Copy link
Contributor

My suggestion is . to adhere to the current action interface and only use a type property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants