diff --git a/actions/activate.php b/actions/activate.php index 08e416d4..9db7969b 100644 --- a/actions/activate.php +++ b/actions/activate.php @@ -22,4 +22,4 @@ redirectTo('/?p=index', 117, __LINE__); } Database::getInstance()->commit(); -redirectTo("/?p=anmelden", 241); +redirectTo('/?p=anmelden', 241); diff --git a/actions/admin_vertrag.php b/actions/admin_vertrag.php index 104762d5..17944bcf 100644 --- a/actions/admin_vertrag.php +++ b/actions/admin_vertrag.php @@ -31,7 +31,7 @@ redirectTo(sprintf('Location: /?p=admin_vertrag_einstellen&von=%d&an=%d&ware=%d&menge=%d&preis=%F', $von, $an, $ware, $menge, $preis), 141, __LINE__); } else { - redirectTo("/?p=admin_vertrag", 218); + redirectTo('/?p=admin_vertrag', 218); die(); } break; @@ -47,7 +47,7 @@ redirectTo(sprintf('Location: /?p=admin_vertrag_bearbeiten&id=%d&von=%d&an=%d&ware=%d&menge=%d&preis=%F', $id, $an, $von, $ware, $menge, $preis), 142, __LINE__); } else { - redirectTo("/?p=admin_vertrag", 234); + redirectTo('/?p=admin_vertrag', 234); } break; @@ -57,7 +57,7 @@ if (Database::getInstance()->deleteTableEntry(Database::TABLE_CONTRACTS, $id) == 0) { redirectBack('/?p=admin_vertrag', 143, __LINE__); } else { - redirectTo("/?p=admin_vertrag", 233); + redirectTo('/?p=admin_vertrag', 233); } break; diff --git a/actions/einstellungen.php b/actions/einstellungen.php index 2840b53d..7fe4bcd4 100644 --- a/actions/einstellungen.php +++ b/actions/einstellungen.php @@ -97,7 +97,6 @@ // Update profile picture case 5: - Database::getInstance()->begin(); if (Database::getInstance()->updateTableEntry(Database::TABLE_USERS, $_SESSION['blm_user'], array('LastImageChange' => date('Y-m-d H:i:s'))) !== 1) { Database::getInstance()->rollBack(); @@ -234,7 +233,7 @@ if ($zip->open($tmpFile, ZipArchive::OVERWRITE) !== true) { redirectTo('/?p=einstellungen', 141, __LINE__); } - $profilePicture = sprintf("../pics/uploads/u_%d.webp", $_SESSION['blm_user']); + $profilePicture = sprintf('../pics/uploads/u_%d.webp', $_SESSION['blm_user']); if (file_exists($profilePicture) && $zip->addFile($profilePicture, 'profile.webp') !== true) { redirectTo('/?p=einstellungen', 141, __LINE__); } @@ -278,7 +277,7 @@ echo file_get_contents($tmpFile); break; -// unknown action + // unknown action default: redirectTo('/?p=einstellungen', 112, __LINE__); break; diff --git a/actions/forschungszentrum.php b/actions/forschungszentrum.php index 3a0ec49b..fc0db494 100644 --- a/actions/forschungszentrum.php +++ b/actions/forschungszentrum.php @@ -33,7 +33,7 @@ Database::getInstance()->begin(); if (Database::getInstance()->createTableEntry(Database::TABLE_JOBS, array( - 'finished' => date("Y-m-d H:i:s", time() + $researchData['Dauer']), + 'finished' => date('Y-m-d H:i:s', time() + $researchData['Dauer']), 'user_id' => $_SESSION['blm_user'], 'item' => (job_type_factor * job_type_research) + $was, 'cost' => $researchData['Kosten'] @@ -57,4 +57,4 @@ } Database::getInstance()->commit(); -redirectTo('/?p=forschungszentrum', 207, "f" . $was); +redirectTo('/?p=forschungszentrum', 207, sprintf('f%s', $was)); diff --git a/actions/gebaeude.php b/actions/gebaeude.php index 5461dca7..f5b54f1d 100644 --- a/actions/gebaeude.php +++ b/actions/gebaeude.php @@ -23,7 +23,7 @@ Database::getInstance()->begin(); if (Database::getInstance()->createTableEntry(Database::TABLE_JOBS, array( - 'finished' => date("Y-m-d H:i:s", time() + $buildingData['Dauer']), + 'finished' => date('Y-m-d H:i:s', time() + $buildingData['Dauer']), 'user_id' => $_SESSION['blm_user'], 'item' => (job_type_factor * job_type_building) + $was, 'cost' => $buildingData['Kosten'] @@ -49,4 +49,4 @@ } Database::getInstance()->commit(); -redirectTo('/?p=gebaeude', 207, "g" . $was); +redirectTo('/?p=gebaeude', 207, sprintf('g%s', $was)); diff --git a/actions/gruppe.php b/actions/gruppe.php index 88d73342..da24f615 100644 --- a/actions/gruppe.php +++ b/actions/gruppe.php @@ -27,7 +27,7 @@ function pinMessage($id, $pinned) } Database::getInstance()->commit(); - redirectTo('/?p=gruppe', 242, "GroupMessages"); + redirectTo('/?p=gruppe', 242, 'GroupMessages'); } switch (getOrDefault($_REQUEST, 'a', 0)) { @@ -147,7 +147,7 @@ function pinMessage($id, $pinned) if (passwordNeedsUpgrade($group['Passwort']) && Database::getInstance()->updateTableEntry(Database::TABLE_GROUP, $group['ID'], array('Passwort' => hashPassword($pwd))) !== 1) { Database::getInstance()->rollBack(); - redirectTo(sprintf("/?p=gruppe&name=%s", urlencode($name)), 142, __LINE__); + redirectTo(sprintf('/?p=gruppe&name=%s', urlencode($name)), 142, __LINE__); } if (Database::getInstance()->updateTableEntry(Database::TABLE_USERS, $_SESSION['blm_user'], array('Gruppe' => $group['ID']), array('Gruppe IS NULL')) !== 1) { @@ -235,7 +235,7 @@ function pinMessage($id, $pinned) case 4: $message = getOrDefault($_POST, 'message'); if (strlen($message) < 4) { - redirectTo(sprintf('/?p=gruppe&message=%s', urlencode($message)), 128, "__LINE__"); + redirectTo(sprintf('/?p=gruppe&message=%s', urlencode($message)), 128, __LINE__); } $player = Database::getInstance()->getPlayerNameAndGroupIdAndGroupRightsById($_SESSION['blm_user']); @@ -254,7 +254,7 @@ function pinMessage($id, $pinned) } Database::getInstance()->commit(); - redirectTo('/?p=gruppe', 204, "GroupMessages"); + redirectTo('/?p=gruppe', 204, 'GroupMessages'); break; // pin message @@ -282,7 +282,7 @@ function pinMessage($id, $pinned) } Database::getInstance()->commit(); - redirectTo('/?p=gruppe', 242, "GroupMessages"); + redirectTo('/?p=gruppe', 242, 'GroupMessages'); break; // --------------------------------------------------------------------------------------- @@ -555,7 +555,7 @@ function pinMessage($id, $pinned) } Database::getInstance()->commit(); - @unlink(sprintf("../pics/uploads/g_%d.webp", $player['Gruppe'])); + @unlink(sprintf('../pics/uploads/g_%d.webp', $player['Gruppe'])); redirectTo('/?p=gruppe', 228, __LINE__); break; diff --git a/actions/login.php b/actions/login.php index 965a827b..40755446 100644 --- a/actions/login.php +++ b/actions/login.php @@ -10,8 +10,8 @@ ob_start(); -$name = requireEntryFound(getOrDefault($_POST, 'name'), "/?p=anmelden", 108, __LINE__); -$pwd = requireEntryFound(getOrDefault($_POST, 'pwd'), "/?p=anmelden", 108, __LINE__); +$name = requireEntryFound(getOrDefault($_POST, 'name'), '/?p=anmelden', 108, __LINE__); +$pwd = requireEntryFound(getOrDefault($_POST, 'pwd'), '/?p=anmelden', 108, __LINE__); // force a new session session_reset(); @@ -19,18 +19,18 @@ // load player data $player = Database::getInstance()->getPlayerDataByName($name); -requireEntryFound($player, sprintf("/?p=anmelden&name=%s", urlencode($name)), 108, __LINE__); +requireEntryFound($player, sprintf('/?p=anmelden&name=%s', urlencode($name)), 108, __LINE__); // check if game is locked if (isGameLocked() && $player['Admin'] != 1) { - redirectTo(sprintf("/?p=anmelden&name=%s", urlencode($name)), 999, __LINE__); + redirectTo(sprintf('/?p=anmelden&name=%s', urlencode($name)), 999, __LINE__); } if ($player['Gesperrt'] == 1) { - redirectTo(sprintf("/?p=anmelden&name=%s", urlencode($name)), 139, __LINE__); + redirectTo(sprintf('/?p=anmelden&name=%s', urlencode($name)), 139, __LINE__); } if ($player['EMailAct'] !== null) { - redirectTo(sprintf("/?p=anmelden&name=%s", urlencode($name)), 135, __LINE__); + redirectTo(sprintf('/?p=anmelden&name=%s', urlencode($name)), 135, __LINE__); } Database::getInstance()->begin(); @@ -49,19 +49,19 @@ 'sitter' => 0 )); Database::getInstance()->commit(); - redirectTo(sprintf("/?p=anmelden&name=%s", urlencode($name)), 108, __LINE__); + redirectTo(sprintf('/?p=anmelden&name=%s', urlencode($name)), 108, __LINE__); } if (!$_SESSION['blm_sitter']) { if (passwordNeedsUpgrade($player['user_password']) && Database::getInstance()->updateTableEntry(Database::TABLE_USERS, $player['ID'], array('Passwort' => hashPassword($pwd))) !== 1) { Database::getInstance()->rollBack(); - redirectTo(sprintf("/?p=anmelden&name=%s", urlencode($name)), 142, __LINE__); + redirectTo(sprintf('/?p=anmelden&name=%s', urlencode($name)), 142, __LINE__); } if (Database::getInstance()->updateTableEntry(Database::TABLE_USERS, $player['ID'], array('LastLogin' => date('Y-m-d H:i:s'), 'LastAction' => date('Y-m-d H:i:s'))) !== 1) { Database::getInstance()->rollBack(); - redirectTo(sprintf("/?p=anmelden&name=%s", urlencode($name)), 142, __LINE__); + redirectTo(sprintf('/?p=anmelden&name=%s', urlencode($name)), 142, __LINE__); } } @@ -73,7 +73,7 @@ 'sitter' => $_SESSION['blm_sitter'] ? 1 : 0 )) !== 1) { Database::getInstance()->rollBack(); - redirectTo(sprintf("/?p=anmelden&name=%s", urlencode($name)), 141, __LINE__); + redirectTo(sprintf('/?p=anmelden&name=%s', urlencode($name)), 141, __LINE__); } Database::getInstance()->commit(); diff --git a/actions/mafia.php b/actions/mafia.php index 5860b06f..d1bdd58b 100644 --- a/actions/mafia.php +++ b/actions/mafia.php @@ -308,7 +308,7 @@ redirectTo($backLink, 141, __LINE__); } - $wares[] = sprintf("* %s: %s", getItemName($i), formatWeight($data['Lager' . $i])); + $wares[] = sprintf('* %s: %s', getItemName($i), formatWeight($data['Lager' . $i])); } if (Database::getInstance()->createTableEntry(Database::TABLE_MESSAGES, array( diff --git a/actions/marktplatz.php b/actions/marktplatz.php index 54efd414..50e38cff 100644 --- a/actions/marktplatz.php +++ b/actions/marktplatz.php @@ -104,7 +104,7 @@ 'Von' => 0, 'An' => $entry['Von'], 'Betreff' => 'Angebot auf freiem Markt verkauft', - 'Nachricht' => sprintf("Soeben wurde das Angebot #%d (%s %s zu insgesamt %s) von einem anonymen Käufer gekauft.", + 'Nachricht' => sprintf('Soeben wurde das Angebot #%d (%s %s zu insgesamt %s) von einem anonymen Käufer gekauft.', $entry['ID'], formatWeight($entry['Menge']), getItemName($entry['Was']), formatCurrency($amount)) )) != 1) { Database::getInstance()->rollBack(); @@ -155,8 +155,8 @@ 'Von' => 0, 'An' => $entry['Von'], 'Betreff' => 'Angebot vom freien Markt zurückgezogen', - 'Nachricht' => sprintf("Das Angebot #%d wurde vom Markt zurückgezogen. Leider sind auf dem Transport und während der Lagerung dort ein Teil der Waren verdorben. - Von den ursprünglichen %s konnten %s wieder in ihr Lager übernommen werden.", + 'Nachricht' => sprintf('Das Angebot #%d wurde vom Markt zurückgezogen. Leider sind auf dem Transport und während der Lagerung dort ein Teil der Waren verdorben. + Von den ursprünglichen %s konnten %s wieder in ihr Lager übernommen werden.', $entry['ID'], formatWeight($entry['Menge']), formatWeight(floor($entry['Menge'] * Config::getFloat(Config::SECTION_MARKET, 'retract_rate')))) )) != 1) { Database::getInstance()->rollBack(); diff --git a/actions/plantage.php b/actions/plantage.php index 872e609a..cfee4b0d 100644 --- a/actions/plantage.php +++ b/actions/plantage.php @@ -79,7 +79,7 @@ Database::getInstance()->begin(); if (Database::getInstance()->createTableEntry(Database::TABLE_JOBS, array( - 'finished' => date("Y-m-d H:i:s", time() + $stunden * 3600), + 'finished' => date('Y-m-d H:i:s', time() + $stunden * 3600), 'user_id' => $_SESSION['blm_user'], 'item' => (job_type_factor * job_type_production) + $was, 'amount' => $menge, @@ -104,4 +104,4 @@ } Database::getInstance()->commit(); -redirectTo('/?p=plantage', 207, "p" . $was); +redirectTo('/?p=plantage', 207, sprintf('p%s', $was)); diff --git a/actions/pwd_reset.php b/actions/pwd_reset.php index 9560fb54..725e6a97 100644 --- a/actions/pwd_reset.php +++ b/actions/pwd_reset.php @@ -69,7 +69,7 @@ function sendPasswordMail(string $email, string $name, string $password): bool if (strtotime($request['created']) < time() - (3600 * 4)) { Database::getInstance()->begin(); if (Database::getInstance()->updateTableEntry(Database::TABLE_PASSWORD_RESET, $request['ID'], - array('created' => date("Y-m-d H:i:s"))) !== 1) { + array('created' => date('Y-m-d H:i:s'))) !== 1) { Database::getInstance()->rollBack(); redirectTo($back_link, 142, __LINE__); } diff --git a/chefbox.php b/chefbox.php index f6a2642a..3da9e001 100644 --- a/chefbox.php +++ b/chefbox.php @@ -142,7 +142,7 @@ $dauer = 1000 * (microtime(true) - $start); ?> Annehmen | Ablehnen diff --git a/pics/profile.php b/pics/profile.php index e8a6e248..c2ef0019 100644 --- a/pics/profile.php +++ b/pics/profile.php @@ -12,26 +12,19 @@ $gid = getOrDefault($_GET, 'gid', 0); if ($uid != 0) { - $prefix = "u"; + $prefix = 'u'; $id = $uid; } else if ($gid != 0) { - $prefix = "g"; + $prefix = 'g'; $id = $gid; } else { die('missing uid/gid parameter'); } -header("Cache-Control: max-age=86400, public"); -$suffixes = array('png' => 'image/png', 'jpg' => 'image/jpeg', 'gif' => 'image/gif', 'webp' => 'image/webp'); -foreach ($suffixes as $suffix => $mimetype) { - $filename = sprintf('uploads/%s_%d.%s', $prefix, $id, $suffix); - if (file_exists($filename)) { - header(sprintf("Content-Type: %s", $mimetype)); - readfile($filename); - die(); - } +$filename = sprintf('uploads/%s_%d.webp', $prefix, $id); +if (!file_exists($filename)) { + $filename = 'style/nopic.webp'; } -// no image found, show fallback image -header("Content-Type: image/webp"); -readfile('style/nopic.webp'); +header('Content-Type: image/webp'); +readfile($filename); diff --git a/tests/build.gradle b/tests/build.gradle index c57a704e..f95f5664 100644 --- a/tests/build.gradle +++ b/tests/build.gradle @@ -41,13 +41,13 @@ test { // use junit 5 useJUnitPlatform() // print status of tests - testLogging { events "passed", "skipped", "failed" } - if (project.hasProperty("webdriver.firefox.bin")) { - systemProperty "webdriver.firefox.bin", project.getProperty("webdriver.firefox.bin") + testLogging { events 'passed', 'skipped', 'failed' } + if (project.hasProperty('webdriver.firefox.bin')) { + systemProperty 'webdriver.firefox.bin', project.getProperty('webdriver.firefox.bin') } } -tasks.named("dependencyUpdates").configure { +tasks.named('dependencyUpdates').configure { gradleReleaseChannel = 'current' revision = 'integration' }