Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Binance Widget] Token options for purchase under .us should be expanded #10209

Closed
ryanml opened this issue Jun 10, 2020 · 1 comment · Fixed by brave/brave-core#5811
Closed

[Binance Widget] Token options for purchase under .us should be expanded #10209

ryanml opened this issue Jun 10, 2020 · 1 comment · Fixed by brave/brave-core#5811
Assignees
@ryanml
Labels
feature/widgets OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.12.x - Release #1

Comments

@ryanml
Copy link
Contributor

ryanml commented Jun 10, 2020

Under Buy Crypto, when the .us TLD is selected, the available list of crypto/tokens to buy should be expanded as follows:

ADA
ALGO
ATOM
BAT
BCH
BNB
BTC
BUSD
ENJ
ETH
HBAR
LINK
MATIC
ONT
RVN
VET
XLM
XRP
XTZ
ZIL
ZRX
@ryanml ryanml added this to the 1.12.x - Nightly milestone Jun 10, 2020
@ryanml ryanml self-assigned this Jun 10, 2020
@ryanml ryanml mentioned this issue Jun 10, 2020
Merged
32 tasks
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.12.103 Chromium: 84.0.4147.89 (Official Build) beta (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{# 852}
OS macOS Version 10.15.5 (Build 19F101)
Verified the following token options are shown when `.us` TDL is selected 
<div class="AssetItems-sc-h3nhy faLWiY">
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-btc AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(247, 147, 26);"></span>
		</span>BTC
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-eth AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(255, 255, 255);"></span>
		</span>ETH
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-bnb AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(243, 186, 47);"></span>
		</span>BNB
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-bch AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(141, 195, 81);"></span>
		</span>BCH
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-xrp AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(52, 106, 169);"></span>
		</span>XRP
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-busd AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(255, 255, 255);"></span>
		</span>BUSD
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-bat AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(158, 31, 99);"></span>
		</span>BAT
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-xtz AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(166, 223, 0);"></span>
		</span>XTZ
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-algo AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(255, 255, 255);"></span>
		</span>ALGO
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-atom AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(46, 49, 72);"></span>
		</span>ATOM
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-link AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(255, 255, 255);"></span>
		</span>LINK
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-vet AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(21, 189, 255);"></span>
		</span>VET
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-zrx AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(255, 255, 255);"></span>
		</span>ZRX
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-ada AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(1, 111, 128);"></span>
		</span>ADA
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-xlm AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(0, 0, 0);"></span>
		</span>XLM
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-enj AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(255, 255, 255);"></span>
		</span>ENJ
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-zil AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(255, 255, 255);"></span>
		</span>ZIL
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-rvn AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(255, 255, 255);"></span>
		</span>RVN
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-ont AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(50, 164, 190);"></span>
		</span>ONT
	</div>
	<div class="AssetItem-sc-ouhi62 eKIVbC">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-hbar AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(255, 255, 255);"></span>
		</span>HBAR
	</div>
	<div class="AssetItem-sc-ouhi62 gCBAQ">
		<span class="DropdownIcon-sc-128uiai dzfHUy">
			<span class="crypto-icon icon-matic AssetIcon-sc-ppg0e5 cOUdkv" style="color: rgb(255, 255, 255);"></span>
		</span>MATIC
	</div>
</div>

image

Verification passed on

Brave 1.12.103 Chromium: 84.0.4147.89 (Official Build) beta (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{# 852}
OS Windows 10 OS Version 1809 (Build 17763.1339)
Verified the following token options are shown when `.us` TDL is selected 
<div class="AssetItems-sc-ii501d cBruon">
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-btc AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(247, 147, 26);"></span>
		</span>BTC
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-eth AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(255, 255, 255);"></span>
		</span>ETH
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-bnb AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(243, 186, 47);"></span>
		</span>BNB
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-bch AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(141, 195, 81);"></span>
		</span>BCH
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-xrp AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(52, 106, 169);"></span>
		</span>XRP
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-busd AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(255, 255, 255);"></span>
		</span>BUSD
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-bat AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(158, 31, 99);"></span>
		</span>BAT
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-xtz AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(166, 223, 0);"></span>
		</span>XTZ
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-algo AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(255, 255, 255);"></span>
		</span>ALGO
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-atom AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(46, 49, 72);"></span>
		</span>ATOM
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-link AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(255, 255, 255);"></span>
		</span>LINK
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-vet AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(21, 189, 255);"></span>
		</span>VET
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-zrx AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(255, 255, 255);"></span>
		</span>ZRX
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-ada AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(1, 111, 128);"></span>
		</span>ADA
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-xlm AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(0, 0, 0);"></span>
		</span>XLM
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-enj AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(255, 255, 255);"></span>
		</span>ENJ
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-zil AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(255, 255, 255);"></span>
		</span>ZIL
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-rvn AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(255, 255, 255);"></span>
		</span>RVN
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-ont AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(50, 164, 190);"></span>
		</span>ONT
	</div>
	<div class="AssetItem-sc-10op0q7 fnIpXT">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-hbar AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(255, 255, 255);"></span>
		</span>HBAR
	</div>
	<div class="AssetItem-sc-10op0q7 bfMqJW">
		<span class="DropdownIcon-sc-1filun7 deZKYC">
			<span class="crypto-icon icon-matic AssetIcon-sc-n6a643 iJpBKM" style="color: rgb(255, 255, 255);"></span>
		</span>MATIC
	</div>
</div>

image

Verification passed on

Brave 1.12.103 Chromium: 84.0.4147.89 (Official Build) beta (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{# 852}
OS Linux
Verified the following token options are shown when `.us` TDL is selected 
<div class="AssetItems-sc-1dfjbyb fSYWqr">
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<div class="AssetItem-sc-6ngj3x bxTYmq">
			<span class="DropdownIcon-sc-37uwoz homCIX">
				<span class="crypto-icon icon-btc AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(247, 147, 26);"></span>
			</span>BTC
		
		</div>
		<div class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-eth AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(255, 255, 255);"></span>
		</div>ETH
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-bnb AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(243, 186, 47);"></span>
		</span>BNB
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-bch AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(141, 195, 81);"></span>
		</span>BCH
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-xrp AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(52, 106, 169);"></span>
		</span>XRP
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-busd AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(255, 255, 255);"></span>
		</span>BUSD
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-bat AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(158, 31, 99);"></span>
		</span>BAT
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-xtz AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(166, 223, 0);"></span>
		</span>XTZ
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-algo AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(255, 255, 255);"></span>
		</span>ALGO
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-atom AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(46, 49, 72);"></span>
		</span>ATOM
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-link AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(255, 255, 255);"></span>
		</span>LINK
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-vet AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(21, 189, 255);"></span>
		</span>VET
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-zrx AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(255, 255, 255);"></span>
		</span>ZRX
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-ada AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(1, 111, 128);"></span>
		</span>ADA
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-xlm AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(0, 0, 0);"></span>
		</span>XLM
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-enj AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(255, 255, 255);"></span>
		</span>ENJ
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-zil AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(255, 255, 255);"></span>
		</span>ZIL
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-rvn AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(255, 255, 255);"></span>
		</span>RVN
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-ont AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(50, 164, 190);"></span>
		</span>ONT
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x bxTYmq">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-hbar AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(255, 255, 255);"></span>
		</span>HBAR
	
	
	</div>
	<div class="AssetItem-sc-6ngj3x gHvoYC">
		<span class="DropdownIcon-sc-37uwoz homCIX">
			<span class="crypto-icon icon-matic AssetIcon-sc-r6uby2 iUUzsy" style="color: rgb(255, 255, 255);"></span>
		</span>MATIC
	
	
	</div>
</div>

image

@LaurenWags LaurenWags mentioned this issue Aug 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
feature/widgets OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging a pull request may close this issue.

Updating Binance widget .us tokens list brave/brave-core
3 participants
@bbondy @ryanml @srirambv