Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entire custom ad notification should be clickable #13137

Closed
tmancey opened this issue Dec 10, 2020 · 2 comments
Closed

Entire custom ad notification should be clickable #13137

tmancey opened this issue Dec 10, 2020 · 2 comments
Assignees
@tmancey
Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.26.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Dec 10, 2020 •
edited
Loading

Description

Steps to Reproduce

  1. View ad notification
  2. Click ad notification outside the text area

Actual result:

Click event is not fired

Expected result:

Click event should be fired

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Confirm working as expected on touch devices such as Windows Surface
@tmancey tmancey added bug priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/ads OS/Desktop labels Dec 10, 2020
@tmancey tmancey mentioned this issue Dec 21, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jan 13, 2021
Closed
@tmancey tmancey self-assigned this Feb 17, 2021
@tmancey tmancey mentioned this issue Mar 7, 2021
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Mar 9, 2021
Closed
@tmancey tmancey changed the title [Ads] Custom ad notification should be clickable anywhere Entire custom ad notification should be clickable Mar 12, 2021
@tmancey tmancey added this to the 1.26.x - Nightly milestone Apr 29, 2021
@tmancey
Copy link
Contributor Author

tmancey commented Apr 29, 2021

Resolved as part of #13132, please test as part of the new custom ad notifications

@tmancey tmancey closed this as completed Apr 29, 2021
@btlechowski btlechowski mentioned this issue Jun 3, 2021
Closed
@btlechowski
Copy link

btlechowski commented Jun 3, 2021 •
edited by GeetaSarvadnya
Loading

Verification passed on

Brave 1.26.50 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS Ubuntu 18.04 LTS

Verified the custom notification is clickable in

  • top-left corner
  • top-right corner
  • bottom-left corner
  • bottom-right corner
  • center
  • on title text
  • on ad content text
  • on Ads icon

Verified clicking on the above opened landing page.
Verified that I got an unblinded token for view

[3724:3724:0603/195656.603666:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id f1bdf6de-0625-4444-a3bc-ea38605ef571, creative instance id 4cda3ae7-1f70-4bca-b361-ca01d6a8f1ed and view

Verified that I got an unblinded token for clicked

[3724:3724:0603/195659.259079:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id 402c126c-2f42-4cd6-b026-685285b9674e, creative instance id 4cda3ae7-1f70-4bca-b361-ca01d6a8f1ed and click

Verified that I got an unblinded token for landed

[3724:3724:0603/195712.749576:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id e6da63d2-d962-4750-85c0-6c81b503ef93, creative instance id 4cda3ae7-1f70-4bca-b361-ca01d6a8f1ed and landed

Verified clicking on x dismissed the ad. The landing page was not opened and unblinded token for dismissed was redeemed:

[504:504:0603/205641.927396:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id d7bd998e-f721-428b-8f40-bbeeadaeb208, creative instance id 4cda3ae7-1f70-4bca-b361-ca01d6a8f1ed and dismiss

Logged #16230 for dismiss area being too big

Verification PASSED on

Brave 1.26.50 Chromium: 91.0.4472.77 (Official Build) beta (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

Verified the custom notification is clickable in

  • top-left corner
  • top-right corner
  • bottom-left corner
  • bottom-right corner
  • center
  • on title text
  • on ad content text
  • on Ads icon

Verified clicking on the above opened landing page.
Verified that I got an unblinded token for view:

[12391:259:0603/122921.828988:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id 98965f18-da99-4198-a50b-8d6298292a1c, creative instance id 6f5decfc-57cb-4a42-8523-e372c7d4adff and view

Verified that I got an unblinded token for clicked:

[12391:259:0603/122928.264963:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id d62537ea-3dcc-4fee-aa79-ac3973a59ce0, creative instance id 6f5decfc-57cb-4a42-8523-e372c7d4adff and click

Verified that I got an unblinded token for landed:

[12391:259:0603/122938.630114:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id c3f5a307-2496-4cb1-9b35-b428a248659d, creative instance id 6f5decfc-57cb-4a42-8523-e372c7d4adff and landed

Verified clicking on x dismissed the ad. The landing page was not opened and unblinded token for dismissed was redeemed:

[12605:259:0603/123625.535000:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id df960ac2-1de8-4ad9-8508-de59c9610cac, creative instance id 2c658159-e18a-4ba7-b4f0-2c51e4eae9ad and dismiss

Verified ad timed-out state:

[12713:259:0603/124040.168913:VERBOSE3:ad_notification_event_timed_out.cc(22)] Timed out ad notification with uuid f0065846-b025-45d9-8aaf-3a9c5f056dde and creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4

Verification passed on

<!--StartFragment-->
Brave | 1.26.50 Chromium: 91.0.4472.77&nbsp;(Official Build)&nbsp;beta&nbsp;(64-bit)
-- | --
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

<!--EndFragment-->

Verified the custom notification is clickable in

  • top-left corner
  • top-right corner
  • bottom-left corner
  • bottom-right corner
  • center
  • on title text
  • on ad content text
  • on Ads icon

Verified clicking on the above opened landing page.

Verified that I got an unblinded token for view

[22444:22496:0604/210900.565:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id 741957ad-bbf8-4cd8-8124-de8c583ccc34, creative instance id 4983dc92-09fd-4e5c-94c3-616a4728c1d9 and view

Verified that I got an unblinded token for click

[22444:22496:0604/210907.255:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id 56935d01-ae79-4c8c-b6e8-e926332448cc, creative instance id 4983dc92-09fd-4e5c-94c3-616a4728c1d9 and click

Verified that I got an unblinded token for landed

[22444:22496:0604/210919.035:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id 4c783ebf-f409-4c97-b2b9-cced56f743c9, creative instance id 4983dc92-09fd-4e5c-94c3-616a4728c1d9 and landed

Verified clicking on x dismissed the ad. The landing page was not opened and unblinded token for dismissed was redeemed:

[4728:16012:0604/212908.956:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id 83357059-1c3e-4546-886e-1004b75558cd, creative instance id 4cda3ae7-1f70-4bca-b361-ca01d6a8f1ed and dismiss

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 3, 2021
@btlechowski btlechowski mentioned this issue Jun 8, 2021
Closed
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.26.x - Release
Development

No branches or pull requests
4 participants
@stephendonner @tmancey @btlechowski @GeetaSarvadnya