Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CNAME-based blocking by reusing Chromium code #13414

Open
iefremov opened this issue Jan 7, 2021 · 2 comments
Open

Improve CNAME-based blocking by reusing Chromium code #13414

iefremov opened this issue Jan 7, 2021 · 2 comments
Assignees
@antonok-edm
Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop privacy-pod Feature work for the Privacy & Web Compatibility pod

Comments

@iefremov
Copy link
Contributor

iefremov commented Jan 7, 2021

In c89 we will have cname aliases plumbed into URLResponseHead [1], that we can reuse for our own profit and avoid making extra dns call in OnBeforeURLRequestAdBlockTP

[1]https://source.chromium.org/chromium/chromium/src/+/master:services/network/public/mojom/url_response_head.mojom;l=227;drc=1f60f34982eb1058a74b77fcc71ffdba05990771?q=url_response_head.m&ss=chromium%2Fchromium%2Fsrc
@iefremov iefremov added OS/Android Fixes related to Android browser functionality OS/Desktop dev-concern labels Jan 7, 2021
@iefremov
Copy link
Contributor Author

iefremov commented Jan 7, 2021

cc @antonok-edm @pes10k

@pes10k pes10k added the privacy-pod Feature work for the Privacy & Web Compatibility pod label Jan 8, 2021
@antonok-edm
Copy link
Collaborator

I believe this is only available starting in Chromium 89, so it's blocked until we upgrade from 88.

@antonok-edm antonok-edm mentioned this issue Feb 2, 2021
Merged
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop privacy-pod Feature work for the Privacy & Web Compatibility pod
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pes10k @iefremov @antonok-edm