Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code style in adblock_rust_ffi #14803

Closed
antonok-edm opened this issue Mar 18, 2021 · 1 comment · Fixed by brave/brave-core#8290
Closed

Update code style in adblock_rust_ffi #14803

antonok-edm opened this issue Mar 18, 2021 · 1 comment · Fixed by brave/brave-core#8290
Assignees
@antonok-edm
Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Milestone
1.24.x - Release

Comments

@antonok-edm
Copy link
Collaborator

The adblock-rust-ffi repo used a different code style compared to brave-core. It should be updated to match.
@antonok-edm antonok-edm added OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 18, 2021
@antonok-edm antonok-edm self-assigned this Mar 18, 2021
@antonok-edm
Copy link
Collaborator Author

I think CI failed to catch this originally because the repo history was kept such that the files were moved without any changes.

This was referenced Mar 18, 2021
Merged
Merged
@antonok-edm antonok-edm added this to the 1.24.x - Nightly milestone Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.24.x - Release
Development

Successfully merging a pull request may close this issue.

Fix lint errors in adblock-rust-ffi brave/brave-core
1 participant
@antonok-edm