Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The search engines dropdown menu doesn't display newly-added search engines properly #16519

Closed
Tonev opened this issue Jun 19, 2021 · 3 comments

Comments

@Tonev
Copy link
Contributor

Tonev commented Jun 19, 2021

Description

Users can't choose a newly-added search engine from the dropdown menu at brave://settings/search unless the newly-added search engine is selected as default at brave://settings/searchEngines.

If users choose another search engine from the dropdown menu later, their previous search engine (the newly-added search engine from my previous sentence) will disappear from the dropdown menu, and users will have to make it default if they want to be able to choose it from the dropdown menu once again.

Steps to Reproduce

  1. Add a search engine at brave://settings/searchEngines
  2. Check the search engines dropdown menu at brave://settings/search
  3. The newly-added search engine won't appear unless you make it default at brave://settings/searchEngines

Actual result:

Q8yHiuF6Id.mp4

Expected result:

Users should be able to select newly-added search engines from the dropdown menu without having to make those search engines their default.

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 1.25.73 Chromium: 91.0.4472.106 (Official Build) (64-bit)
Revision 574f7b38e4e7244c92c4675e902e8f8e3d299ea7-refs/branch-heads/4472@{#1477}
OS Windows 7 Service Pack 1 (Build 7601)
JavaScript V8 9.1.269.36
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.106 Safari/537.36
Command Line "C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe" --enable-dom-distiller --disable-domain-reliability --no-pings --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --enable-features=PrefetchPrivacyChanges,LegacyTLSEnforced,SafetyTip,WinrtGeolocationImplementation,AutoupgradeMixedContent,WebUIDarkMode,PasswordImport,ReducedReferrerGranularity --disable-features=LangClientHintHeader,InterestCohortAPIOriginTrial,FirstPartySets,FlocIdComputedEventLogging,HandwritingRecognitionWebPlatformApiFinch,HandwritingRecognitionWebPlatformApi,AutofillEnableAccountWalletStorage,FledgeInterestGroupAPI,EnableProfilePickerOnStartup,TextFragmentAnchor,FledgeInterestGroups,InterestCohortFeaturePolicy,SignedExchangePrefetchCacheForNavigations,NetworkTimeServiceQuerying,SubresourceWebBundles,IdleDetection,NotificationTriggers,WebOTP,SignedExchangeSubresourcePrefetch,DirectSockets,TrustTokens,TabHoverCards,SharingQRCodeGenerator,FederatedLearningOfCohorts,AutofillServerCommunication,LiveCaption --flag-switches-begin --enable-features=PrefetchPrivacyChanges,LegacyTLSEnforced,SafetyTip,WinrtGeolocationImplementation,AutoupgradeMixedContent,WebUIDarkMode,PasswordImport,ReducedReferrerGranularity,EphemeralStorage --flag-switches-end
Executable Path C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe
Profile Path C:\Users\User\AppData\Local\BraveSoftware\Brave-Browser\User Data\Default
Variations aed3cac0-3f4a17df7146a73c-3f4a17dfc63a3c82-3f4a17df

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron
Copy link
Collaborator

rebron commented Jun 21, 2021

Closing as wontfix. This is working as expected as the list in that the drop down are the default search engines that ship with the browser. The number of search engines available via the drop down list could be exceptionally long if we add all the opensearch engines in there.

@Tonev
Copy link
Contributor Author

Tonev commented Jun 22, 2021

Not that my comment will change anything, but I'll reply anyway.

The number of search engines available via the drop down list could be exceptionally long if we add all the opensearch engines in there.

If only the predefined default search engines + manually-added search engines are displayed in the dropdown menu, the list won't become exceptionally long. Right now, you're limiting Brave users to seeing only the search engines the developers have selected as default for one reason or another. There is absolutely no need to display every search engine that Brave adds at brave://settings/searchEngines, or in other words: https://community.brave.com/t/how-does-other-search-engines-added/261224.

What you're describing as "working as expected" might be true, but at the same time the feature is limiting users only to Brave's predefined "default" search engines, which could be changed for better.

Best regards.

@Tonev
Copy link
Contributor Author

Tonev commented Aug 11, 2021

@rebron

Is this still a wontfix if brave/brave-core#9602 is the first step in implementing what I suggested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants