Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Talk promo tooltip isn't shown for the existing user after the upgrade to 1.28.x #17420

Open
GeetaSarvadnya opened this issue Aug 10, 2021 · 1 comment
Labels
bug feature/brave-talk OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 10, 2021

Description

Found while testing #16312

Brave Talk promo tooltip isn't shown for the existing user even when the user has not interacted with NTP brave talk in the older versions

Attention will also be drawn to the icon with a promo tooltip that points to it. The promo tooltip shows to:
Existing users - as soon as the user updates Brave to a supported version. If the user does not interact with it, it shows on the new tab page for a total view time of 4 seconds spread across new tab pages.
New users - 3 days after install. If the user does not interact with it, it shows on the new tab page for a total view time of 4 seconds spread across new tab pages.

Steps to Reproduce

  1. Open any older profile of brave 1.27.x where the user has not interacted with NTP brave talk
  2. Upgrade the profile to 1.28.105
  3. Confirmed Brave talk study is enabled in brave://versions
  4. Brave talk promo tooltip isn't shown in a new NTP/existing new tab page

(launched brave using brave.exe --variations-server-url=https://variations.bravesoftware.com/seed in 1.28.105)

Actual result:

Brave Talk promo tooltip isn't shown for the existing user even when the user has not interacted with NTP brave talk in the older version
image

Expected result:

As per the expected result mentioned in the description, the brave talk promo should be shown in NTP for the existing user as soon as they upgrade the profile to the supported region

image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.28.105 Chromium: 92.0.4515.131 (Official Build) (64-bit)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS Windows 10 OS Version 2009 (Build 19043.1110)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Not sure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @petemill

@GeetaSarvadnya GeetaSarvadnya changed the title Brave Talk promo tooltip isn't shown for the existing user even when the user has not interacted with NTP brave talk in the older version Brave Talk promo tooltip isn't shown for the existing user after the upgrade to 1.28.x Aug 10, 2021
@stephendonner
Copy link

@rebron @mattmcalister this might make for a good follow-up candidate, to help drive more adoption/pickup 👍

@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/brave-talk OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

4 participants