Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave News Display Ad gets served more than once #17471

Closed
petemill opened this issue Aug 12, 2021 · 1 comment · Fixed by brave/brave-core#9743
Closed

Brave News Display Ad gets served more than once #17471

petemill opened this issue Aug 12, 2021 · 1 comment · Fixed by brave/brave-core#9743

Comments

@petemill
Copy link
Member

petemill commented Aug 12, 2021

Test plan

See brave/brave-core#9743

Description

Occurs for first ad position - ad content will get requested twice. The first response will be discarded and the second response will be used. This results in premature ad capping from the ads service.

The only way to monitor the issue on the current build is to check the ads service local SQL database. The fix will contain more debug logging.

@petemill petemill self-assigned this Aug 12, 2021
@bsclifton bsclifton added this to the 1.30.x - Nightly milestone Aug 13, 2021
@rebron rebron changed the title [Desktop] Brave News Display Ad gets served more than once Brave News Display Ad gets served more than once Aug 19, 2021
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 23, 2021
@stephendonner
Copy link

Verified PASSED using

Brave 1.29.67 Chromium: 92.0.4515.159 (Official Build) beta (x86_64)
Revision 0185b8a19c88c5dfd3e6c0da6686d799e9bc3b52-refs/branch-heads/4515@{#2052}
OS macOS Version 11.5.2 (Build 20G95)

Steps:

  1. new profile
  2. launched Brave
  3. opened the "hamburger" menu, and chose More Tools -> Developer Tools
  4. from the All levels dropdown, added Verbose
  5. opened a new-tab page
  6. scrolled down
  7. examined console

Confirmed I only saw one asking for an ad 0 call logged in the Console

Screen Shot 2021-08-23 at 1 04 22 PM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment