Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no enable/disable search tab settings in Guest window #17586

Closed
GeetaSarvadnya opened this issue Aug 20, 2021 · 1 comment
Closed

There is no enable/disable search tab settings in Guest window #17586

GeetaSarvadnya opened this issue Aug 20, 2021 · 1 comment

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 20, 2021

Description

Found while testing #16007
There is no enable/disable search tab settings in Guest window

Steps to Reproduce

  1. Clean profile 1.29.64
  2. Disable search tab settings in brave://settings/appearance
  3. Make sure the Show tab search button feature icon is disabled in the top right of the tab strip in Normal window/Private/TOR windows
  4. Open a Guest window, the search tab feature icon is still enabled in the top right of the tab strip in Guest window

Actual result:

There is no enable/disable search tab settings in Guest window
image

Expected result:

enable/disable search tab settings should be present in the Guest window

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.29.64 Chromium: 92.0.4515.159 (Official Build) beta (64-bit)
Revision 0185b8a19c88c5dfd3e6c0da6686d799e9bc3b52-refs/branch-heads/4515@{#2052}
OS Windows 10 OS Version 2009 (Build 19043.1165)

Version/Channel Information:

  • Can you reproduce this issue with the current release?Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @petemill @karenkliu @rebron

@rebron
Copy link
Collaborator

rebron commented Aug 26, 2021

Closing as won't fix. We don't want to support anything other the search settings in Guest Window as Guest window is meant to be temporary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants