Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The segment is blocked but ads history indicates that it is not #17672

Closed
btlechowski opened this issue Aug 24, 2021 · 1 comment · Fixed by brave/brave-core#9856
Closed

The segment is blocked but ads history indicates that it is not #17672

btlechowski opened this issue Aug 24, 2021 · 1 comment · Fixed by brave/brave-core#9856

Comments

@btlechowski
Copy link

After user blocks a segment in ads history, it may happen that the indicator will be reset. User may think that the segment is not blocked when in fact it is blocked.

Steps to Reproduce

  1. Use catalog:
    notification ad - blocked untargeted segment v8.txt
  2. Run Brave with:
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6  --brave-ads-staging --brave-ads-debug --rewards=staging=true --brave-today-host=brave-today-cdn.bravesoftware.com --variations-server-url=https://no-thanks.invalid --enable-features="AdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:should_show_custom_notifications/true/ad_notification_timeout/0/ad_notification_fade_duration/2000"
  1. Enable rewards and ads
  2. Trigger a notification ad (do not dismiss/click it)
  3. Open 30-day history
  4. Block the ad segment
  5. Dismiss the ad
  6. Reload 30-day history

Note: also noticed that this happens when certain amount of time passes but could find exactly how long is needed

Actual result:

The segment is blocked but ads history indicates that it is not
blocked icon is reset to unblocked icon

Note: UI change is permanent, not fixed after browser restart

Expected result:

The segment is blocked but ads history indicates that it is indeed blocked

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.29.67 Chromium: 92.0.4515.159 (Official Build) beta (64-bit)
Revision 0185b8a19c88c5dfd3e6c0da6686d799e9bc3b52-refs/branch-heads/4515@{#2052}
OS Linux

cc @tmancey @moritzhaller @jsecretan @rebron @brave/legacy_qa

@btlechowski
Copy link
Author

Verification passed on

Brave 1.29.75 Chromium: 93.0.4577.58 (Official Build) (64-bit)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS Linux

Verified Icon is updated
blocked icon is reset to unblocked icon fixed2

Verified ads are blocked:

[11657:11657:0830/144131.908464:VERBOSE1:eligible_ad_notifications.cc(87)] Get eligible ads for parent-child segments:
[11657:11657:0830/144131.908657:VERBOSE1:eligible_ad_notifications.cc(89)]   personal finance-personal finance
[11657:11657:0830/144131.908722:VERBOSE1:eligible_ad_notifications.cc(89)]   home-appliances
[11657:11657:0830/144131.908752:VERBOSE1:eligible_ad_notifications.cc(89)]   food & drink-vegetarian
[11657:11657:0830/144131.909745:VERBOSE1:eligible_ad_notifications.cc(100)] No eligible ads for parent-child segments
[11657:11657:0830/144131.909804:VERBOSE1:eligible_ad_notifications.cc(122)] Get eligible ads for parent segments:
[11657:11657:0830/144131.909875:VERBOSE1:eligible_ad_notifications.cc(124)]   personal finance
[11657:11657:0830/144131.909905:VERBOSE1:eligible_ad_notifications.cc(124)]   home
[11657:11657:0830/144131.909946:VERBOSE1:eligible_ad_notifications.cc(124)]   food & drink
[11657:11657:0830/144131.910728:VERBOSE1:eligible_ad_notifications.cc(135)] No eligible ads for parent segments
[11657:11657:0830/144131.910777:VERBOSE1:eligible_ad_notifications.cc(147)] Get eligble ads for untargeted segment
[11657:11657:0830/144131.911524:VERBOSE1:eligible_ad_notifications.cc(159)] No eligible ads for untargeted segment
[11657:11657:0830/144131.922968:VERBOSE1:ad_notification_serving.cc(121)] Ad notification not served: No eligible ads found

Verified able to unblock and indicator is updated:
image

Verified ads are shown after unblocking:

[11657:11657:0830/144323.172215:VERBOSE1:eligible_ad_notifications.cc(87)] Get eligible ads for parent-child segments:
[11657:11657:0830/144323.172406:VERBOSE1:eligible_ad_notifications.cc(89)]   technology & computing-software
[11657:11657:0830/144323.172575:VERBOSE1:eligible_ad_notifications.cc(89)]   personal finance-personal finance
[11657:11657:0830/144323.172700:VERBOSE1:eligible_ad_notifications.cc(89)]   home-appliances
[11657:11657:0830/144323.173475:VERBOSE1:eligible_ad_notifications.cc(100)] No eligible ads for parent-child segments
[11657:11657:0830/144323.173615:VERBOSE1:eligible_ad_notifications.cc(122)] Get eligible ads for parent segments:
[11657:11657:0830/144323.173752:VERBOSE1:eligible_ad_notifications.cc(124)]   technology & computing
[11657:11657:0830/144323.173874:VERBOSE1:eligible_ad_notifications.cc(124)]   personal finance
[11657:11657:0830/144323.174045:VERBOSE1:eligible_ad_notifications.cc(124)]   home
[11657:11657:0830/144323.175009:VERBOSE1:seen_advertisers.h(29)] All ad_notifications have been shown, so round robin
[11657:11657:0830/144323.175148:VERBOSE1:client.cc(482)] Resetting seen ad_notification advertisers
[11657:11657:0830/144323.177374:VERBOSE2:ad_priority.h(32)] 1 ads with a priority of 1 in bucket 1
[11657:11657:0830/144323.177981:VERBOSE1:ad_notification_serving.cc(126)] Found 1 eligible ads
[11657:11657:0830/144323.178940:VERBOSE1:ad_notification_serving.cc(222)] Serving ad notification:
  uuid: fefddad8-d339-4fb2-aa91-ce8eb52550b0
  creativeInstanceId: ed6c467a-8643-42eb-a7cd-32e878fa3cd4
  creativeSetId: a9f0b49c-3298-4c1b-a8b5-76a71e8d7332
  campaignId: 0e70c893-b0c0-4dab-860d-7e65446f0f0f
  advertiserId: 8d2f4191-b76e-4369-8983-3d9ff551c5ad
  segment: technology & computing
  title: technology & computing - ad 1
  body: technology & computing - ad 1
  targetUrl: https://www.brave.com
[11657:11657:0830/144323.232752:VERBOSE3:ad_notification_event_served.cc(25)] Served ad notification with uuid fefddad8-d339-4fb2-aa91-ce8eb52550b0 and creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4
[11657:11657:0830/144323.233006:VERBOSE1:ad_notification_serving.cc(137)] Served ad notification
[11657:11657:0830/144323.237495:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid fefddad8-d339-4fb2-aa91-ce8eb52550b0 and creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4
[11657:11657:0830/144323.237903:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4
[11657:11657:0830/144323.240580:VERBOSE1:redeem_unblinded_token.cc(50)] Redeem unblinded token
[11657:11657:0830/144323.241257:VERBOSE1:redeem_unblinded_token.cc(64)] CreateConfirmation
[11657:11657:0830/144323.241557:VERBOSE2:redeem_unblinded_token.cc(65)] POST /v1/confirmation/{confirmation_id}/{credential}
[11657:11657:0830/144323.241723:VERBOSE5:redeem_unblinded_token.cc(69)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/2ac5db78-436d-4fb8-b3eb-5544f460e072/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiTHF3aGhtTm82YVo3RzNZOXBUcmNWRnJxOTJVUkRSaDMwditSRFo3SGJSVT1cIixcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIlVTXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcImVkNmM0NjdhLTg2NDMtNDJlYi1hN2NkLTMyZTg3OGZhM2NkNFwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcImxpbnV4XCIsXCJzdHVkaWVzXCI6W10sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoidWV3ZDNNaHlsU213c0J5VU5TWERmdHRuNEV6eEtOcU1aUGttK3ZhOC9IUVdkZWtoYW5OdUFueSs0OXZwUWJiZWxUcG9lZ2xKNnMyYWkwdThKVGlCK0E9PSIsInQiOiJrVEhjbHdUUXlIaUhRU0hwbjl6QXJyTU5SekdlSzkwKy9TcHB1VUhPZkZxRUZjZWxJN3dXbmRRY0RsSzhYMDI3aFBxZlVHYWFGZ0JCeWVHYjdJNHRFZz09In0=
  Content: {"blindedPaymentToken":"LqwhhmNo6aZ7G3Y9pTrcVFrq92URDRh30v+RDZ7HbRU=","buildChannel":"release","countryCode":"US","creativeInstanceId":"ed6c467a-8643-42eb-a7cd-32e878fa3cd4","payload":{},"platform":"linux","studies":[],"type":"view"}
  Content Type: application/json
  Method: POST
[11657:11657:0830/144323.248877:VERBOSE1:ad_notification_event_served.cc(33)] Successfully logged ad notification served event
[11657:11657:0830/144323.271053:VERBOSE6:ad_notification_event_viewed.cc(32)] Successfully logged ad notification viewed event
[11657:11657:0830/144323.643942:VERBOSE1:redeem_unblinded_token.cc(82)] OnCreateConfirmation
[11657:11657:0830/144323.644768:VERBOSE6:redeem_unblinded_token.cc(84)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/2ac5db78-436d-4fb8-b3eb-5544f460e072/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiTHF3aGhtTm82YVo3RzNZOXBUcmNWRnJxOTJVUkRSaDMwditSRFo3SGJSVT1cIixcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIlVTXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcImVkNmM0NjdhLTg2NDMtNDJlYi1hN2NkLTMyZTg3OGZhM2NkNFwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcImxpbnV4XCIsXCJzdHVkaWVzXCI6W10sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoidWV3ZDNNaHlsU213c0J5VU5TWERmdHRuNEV6eEtOcU1aUGttK3ZhOC9IUVdkZWtoYW5OdUFueSs0OXZwUWJiZWxUcG9lZ2xKNnMyYWkwdThKVGlCK0E9PSIsInQiOiJrVEhjbHdUUXlIaUhRU0hwbjl6QXJyTU5SekdlSzkwKy9TcHB1VUhPZkZxRUZjZWxJN3dXbmRRY0RsSzhYMDI3aFBxZlVHYWFGZ0JCeWVHYjdJNHRFZz09In0=
  Response Status Code: 201
  Response: {"id":"2ac5db78-436d-4fb8-b3eb-5544f460e072","payload":{},"createdAt":"2021-08-30T12:21:30.044Z","type":"view","modifiedAt":"2021-08-30T12:21:30.044Z","creativeInstanceId":"ed6c467a-8643-42eb-a7cd-32e878fa3cd4"}
[11657:11657:0830/144323.645171:VERBOSE1:redeem_unblinded_token.cc(112)] FetchPaymentToken
[11657:11657:0830/144323.645299:VERBOSE2:redeem_unblinded_token.cc(113)] GET /v1/confirmation/{confirmation_id}/paymentToken
[11657:11657:0830/144323.645439:VERBOSE5:redeem_unblinded_token.cc(117)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/2ac5db78-436d-4fb8-b3eb-5544f460e072/paymentToken
  Method: GET
[11657:11657:0830/144323.916353:VERBOSE1:redeem_unblinded_token.cc(128)] OnFetchPaymentToken
[11657:11657:0830/144323.916497:VERBOSE6:redeem_unblinded_token.cc(130)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/2ac5db78-436d-4fb8-b3eb-5544f460e072/paymentToken
  Response Status Code: 200
  Response: {"id":"2ac5db78-436d-4fb8-b3eb-5544f460e072","createdAt":"2021-08-30T12:21:30.044Z","type":"view","modifiedAt":"2021-08-30T12:21:30.072Z","creativeInstanceId":"ed6c467a-8643-42eb-a7cd-32e878fa3cd4","paymentToken":{"publicKey":"CrQLMWmUuYog6Q93nScS8Lo1HHSex8WM2Qxij7qhjkQ=","batchProof":"yaZLnw12IHLyKzEYdOtboAXAlI/Z9w1lqPMLBe5cUQpr7mZ3M54tRg4SiH4YAGWYDxDqjOIvHot+8J5/n9/gBw==","signedTokens":["ViVEHKYydEtUAWYSZangVgWThxPe6VZ/eLgM+EJqoyE="]}}
[11657:11657:0830/144323.916741:VERBOSE1:confirmations.cc(250)] Successfully redeemed unblinded token with confirmation id 2ac5db78-436d-4fb8-b3eb-5544f460e072, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and view
[11657:11657:0830/144323.916873:VERBOSE1:confirmations.cc(273)] Added 1 unblinded payment token with an estimated redemption value of 0.025 BAT, you now have 3 unblinded payment tokens

@btlechowski btlechowski added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 30, 2021
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants