Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Brave ads dev environment #17812

Closed
tmancey opened this issue Sep 1, 2021 · 2 comments · Fixed by brave/brave-core#10089
Closed

Remove Brave ads dev environment #17812

tmancey opened this issue Sep 1, 2021 · 2 comments · Fixed by brave/brave-core#10089

Comments

@tmancey
Copy link
Contributor

tmancey commented Sep 1, 2021

No description provided.

@tmancey tmancey self-assigned this Sep 14, 2021
@tmancey tmancey added QA/Yes release-notes/exclude priority/P4 Planned work. We expect to get to it "soon". labels Sep 14, 2021
@tmancey tmancey added this to the 1.31.x - Nightly milestone Sep 15, 2021
@tmancey tmancey added the OS/Android Fixes related to Android browser functionality label Sep 15, 2021
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 29, 2021
@stephendonner
Copy link

stephendonner commented Sep 30, 2021

Verified PASSED using

Brave 1.31.66 Chromium: 94.0.4606.61 (Official Build) beta (x86_64)
Revision 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS macOS Version 11.6 (Build 20G165)

Staging (--brave-ads-staging --rewards=staging=true)

Steps:

  1. new profile
  2. launched Brave --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
  3. open a new-tab page
  4. click the Start using Rewards button
  5. scrolled down on the new-tab page
  6. clicked on Show Brave News
  7. scrolled down to find an inline-content ad
  8. viewed the ad
  9. opened brave://rewards and the new-tab page
  10. confirmed I was paid for viewing the ad
  11. waited
  12. resumed activity on computer after some time
  13. viewed system-notification ad
  14. confirmed via the NTP and brave://rewards I was rewarded for viewing it
  15. viewed a promoted-content ad in Brave News
  16. confirmed via the NTP and brave://rewards I was rewarded for viewing it
  17. viewed a NTP sponsored image, but wasn't rewarded for it
ad type brave://rewards / actual ad NTP widget / error
system notification Screen Shot 2021-09-28 at 10 39 47 PM Screen Shot 2021-09-28 at 10 42 45 PM
NTP SI Screen Shot 2021-09-29 at 4 33 25 PM [4989:259:0929/163219.627191:VERBOSE1:new_tab_page_ad.cc(64)] Failed to fire new tab page ad event due to missing creative instance id 5a6770ec-79b3-4adf-82ba-c087dfcb65ad
inline content Screen Shot 2021-09-28 at 10 29 44 PM Screen Shot 2021-09-29 at 4 04 21 PM
promoted content Screen Shot 2021-09-30 at 8 41 27 AM Screen Shot 2021-09-30 at 8 43 01 AM

Production

Steps:

  1. new profile
  2. launched Brave --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6
  3. opened a new-tab page with a sponsored image
  4. confirmed I was paid for viewing the ad
  5. waited a while
  6. started typing
  7. viewed a system-notification ad
  8. confirmed I was paid for viewing the ad
  9. opened a new-tab page
  10. viewed a sponsored-image ad, but wasn't rewarded
  11. wasn't able to view any inline-content ads
  12. viewed a promoted-content ad, but wasn't rewarded for it
ad type brave://rewards / ad NTP widget / error
system notification Screen Shot 2021-09-28 at 11 06 14 PM Screen Shot 2021-09-28 at 11 06 35 PM
NTP SI Screen Shot 2021-09-28 at 10 53 17 PM Screen Shot 2021-09-28 at 10 53 27 PM
inline content unavailable at time of testing (did not appear) unavailable at time of testing (did not appear)
promoted content Screen Shot 2021-09-29 at 4 51 13 PM [5280:259:0929/165049.368080:VERBOSE1:promoted_content_ad.cc(64)] Failed to fire promoted content ad event due to missing creative instance id d2d506aa-5531-4069-8f85-7d9052f1b640

Development (--rewards=development=true)

  1. new profile
  2. launched Brave using --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-debug --brave-ads-development --rewards=development=true

Got development endpoints:

> Url: https://api.rewards.brave.software/v1/parameters, which returned 20x responses.

Screen Shot 2021-09-29 at 5 09 44 PM

Chasing this last issue up with @tmancey and will file a spinoff bug if needed.

@stephendonner stephendonner added QA Pass-macOS QA/No and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/No labels Sep 30, 2021
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 11 running 1.31.86 x64 build

  • Verified ads work fine on production environment
  • Verified ads work fine on staging environment

Verification passed on Samsung Tab A with Android 10 running 1.31.86 x64 build

  • Verified ads work fine on production environment
  • Verified ads work fine on staging environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants