Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script Blocking is not enabled by default, and on Android the scripts can't be Allowed individually after turning on the script blocking in the settings when they can be on the desktop browser #17880

Open
life777eternal opened this issue Sep 5, 2021 · 3 comments
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@life777eternal
Copy link

life777eternal commented Sep 5, 2021

Description

The scripts are not blocked by default in the Shields Settings, and on the Mobile Android app, after the scripts are blocked in the settings or on an individual site, they can't be allowed individually like on the desktop browser. This would emulate the "NoScript" extension for Firefox, which I actually was using on Firefox.

Steps to Reproduce

  1. Open any web page
  2. Click on the Lion / Brave Shields settings icon & notice that the scripts are not blocked
  3. Click on the link for "Change 'global' shield defaults"
  4. In the Shield Defaults settings, click on "Block Scripts" to enable the script blocking on all websites.
  5. Then on each website click the Lion / Brave Shields settings icon again and allow the scripts individually.

Actual result:

Scripts are not blocked by default. On Android the scripts can't be allowed individually after they are blocked. Most websites have more than one script. One on the website domain and usually several others.

Expected result:

Almost every website now has the "google tag manager" script and if we don't want the Google Scripts, the script blocking would have to be enabled in the settings, and it probably should be enabled by default. Also the scripts should be able to be allowed individually on the Android browser. Also there needs to be an option to allow the scripts always, not just once. Otherwise it's too time consuming to block the scripts, and then allow the good ones. And I had to disable the script blocking to edit this.

Reproduces how often:

Always.

Desktop Brave version:

Brave 1.25.72 Chromium: 91.0.4472.101 (Official Build) (64-bit)
Revision af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Android Device details:

  • Install type (ARM, x86): ???????
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Version/Channel Information:

Same on Brave Beta.

  • Can you reproduce this issue with the current release? Is the version I have not the current release?
  • Can you reproduce this issue with the beta channel? Aye
  • Can you reproduce this issue with the nightly channel? Don't know, haven't used that one.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? You mean on the latest version of Chromium, right-o? Chrome is just Google's version of Chromium. Probably not, Chromium/Chrome doesn't have the Brave Shields feature.

Miscellaneous Information:

@life777eternal life777eternal added OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 5, 2021
@Tonev
Copy link
Contributor

Tonev commented Sep 6, 2021

The Block scripts feature of Brave Shields disables JavaScript, and it's no secret that the vast majority of websites use JavaScript to function properly. If Brave Shields was blocking JavaScript by default, you would run into web compatibility issues upon your first launch of the browser.

Almost every website now has the "google tag manager" script and if we don't want the Google Scripts, the script blocking would have to be enabled in the settings, and it probably should be enabled by default.

Brave Shields blocks such scripts via filter lists, there is no need to disable JavaScript for that.

CC: @ryanbr

@srirambv
Copy link
Contributor

srirambv commented Sep 7, 2021

cc: @karenkliu for design to bridge parity between desktop

@anthonypkeane to prioritize

@srirambv srirambv added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/shields The overall Shields feature in Brave. and removed OS/Desktop labels Sep 7, 2021
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 7, 2021
@life777eternal
Copy link
Author

The Block scripts feature of Brave Shields disables JavaScript, and it's no secret that the vast majority of websites use JavaScript to function properly. If Brave Shields was blocking JavaScript by default, you would run into web compatibility issues upon your first launch of the browser.

Almost every website now has the "google tag manager" script and if we don't want the Google Scripts, the script blocking would have to be enabled in the settings, and it probably should be enabled by default.

Brave Shields blocks such scripts via filter lists, there is no need to disable JavaScript for that.

Aye it does block the scripts and mostly all websites use Javascript now. That's why an "Allow Always" option would be needed if the Scripts are always blocked by default in the settings. And I have noticed that some scripts are blocked by default already when opening the Inspect view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

4 participants