-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate bubble isn't shown when the non-English site is visited #19300
Comments
cc: @atuchin-m |
The result of #18593 |
This doesn't seem to be cr96-related as 1.32.x with cr96 (and without #18593) works the same way as 1.31.x does. However, in 1.33.x with #18593 (but with #brave-translate-go disabled) I don't see the bubble that offers to install the Google Translate extension for languages like Chinese (http://news.cn/) or Hindi (https://www.aajtak.in/), so something isn't quite as expected, @atuchin-m? |
That's correct @mkarolin.
It's the same problem. The correct description of the bug is: |
Verified
Steps:
Confirmed, for each, there was a dialog prompting to install Google Translate.
Verified
Steps:
Confirmed, for each, there was a dialog prompting to install Google Translate.
Verified
Steps:
Confirmed, for each, there was a dialog prompting to install Google Translate.
|
Description
CR96 - Translate bubble isn't shown when the non-English site is visited
Steps to Reproduce
1.33.69
Actual result:
The translate bubble isn't shown
![image](https://user-images.githubusercontent.com/38657976/140864781-2c397609-43a9-470c-88af-fe97eaadfb4c.png)
Expected result:
Translate bubble should be shown
1.31.x
![image](https://user-images.githubusercontent.com/38657976/140864817-0e065477-8b0d-4036-b021-3fd3f72a083c.png)
Reproduces how often:
Easy
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @brave/legacy_qa @mkarolin @rebron
The text was updated successfully, but these errors were encountered: