Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show seed words in red when they are not selected in order #19736

Closed
srirambv opened this issue Nov 25, 2021 · 3 comments · Fixed by brave/brave-core#11926
Closed

Show seed words in red when they are not selected in order #19736

srirambv opened this issue Nov 25, 2021 · 3 comments · Fixed by brave/brave-core#11926
Assignees

Comments

@srirambv
Copy link
Contributor

Description

For ease of use, we should show seed words in red when a word is selected in the wrong position, similar to how it works on iOS

Steps to reproduce

  1. Create Wallet
  2. Select backup
  3. Randomly tap words

Actual result

Third seed word is wrong in this case

Expected result

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.33.90 x64 Beta build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @jamesmudgett @SergeyZhukovsky

@srirambv srirambv added suggestion usability QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Nov 25, 2021
@bbondy
Copy link
Member

bbondy commented Nov 26, 2021

great idea

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 26, 2021
@muliswilliam muliswilliam self-assigned this Jan 20, 2022
@muliswilliam muliswilliam added this to the 1.36.x - Nightly milestone Jan 20, 2022
@srirambv
Copy link
Contributor Author

srirambv commented Feb 4, 2022

Brave 1.36.83 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11926
  • Verified selecting a word in the wrong position causes it to show up in red
19736-Linux.mp4
197336-Windows.mov
19736-macOS.mov

@srirambv
Copy link
Contributor Author

srirambv commented Feb 4, 2022

Android specific issue logged #20886 and removing Android label

@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants