Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show backup wallet message when you restore account from seed #19966

Closed
srirambv opened this issue Dec 7, 2021 · 1 comment · Fixed by brave/brave-core#11595
Closed

Do not show backup wallet message when you restore account from seed #19966

srirambv opened this issue Dec 7, 2021 · 1 comment · Fixed by brave/brave-core#11595
Assignees
@wchen342
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.35.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Dec 7, 2021

Description

Similar to #18827, we should not show backup wallet message when you restore account from seed

Steps to reproduce

  1. Enable wallet
  2. Restore account from seed
  3. Portfolio shows backup wallet message

Actual result

Portfolio shows backup wallet message when account is restored from seed

Expected result

Do not show backup wallet message when you restore account from seed

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? YEs

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.33.100

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @SergeyZhukovsky @wchen342
@srirambv srirambv added QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Dec 7, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 7, 2021
@wchen342 wchen342 self-assigned this Dec 10, 2021
@wchen342 wchen342 mentioned this issue Dec 14, 2021
Merged
25 tasks
@wchen342 wchen342 added this to the 1.35.x - Nightly milestone Dec 14, 2021
@srirambv
Copy link
Contributor Author

srirambv commented Jan 11, 2022 •
edited
Loading

Verification passed on Oppo Reno 5 with Android 11 running 1.35.79 x64 Beta build

  • Verified steps from issue description
  • Verified no backup wallet message is shown when a wallet is restored

Verification passed on Samsung Tab A with Android 10running 1.35.79 x64 Beta build

  • Verified steps from issue description
  • Verified no backup wallet message is shown when a wallet is restored

@kjozwiak kjozwiak mentioned this issue Feb 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wchen342 wchen342

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
1.35.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] hide backup banner when restored from seed brave/brave-core
3 participants
@bbondy @wchen342 @srirambv