Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest unlimited approvals as default in Swap #21198

Closed
onyb opened this issue Feb 18, 2022 · 2 comments · Fixed by brave/brave-core#12337
Closed

Suggest unlimited approvals as default in Swap #21198

onyb opened this issue Feb 18, 2022 · 2 comments · Fixed by brave/brave-core#12337
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA/Yes release-notes/include

Comments

@onyb
Copy link
Member

onyb commented Feb 18, 2022

Brave Wallet currently suggests the current balance as a the default allowance value on the token contracts for 0x exchange proxy. This is done for security reasons, but creates a lot of friction in the UX and costs a lot in fees due to repeated on-chain transactions. The proposal is to have one-time Unlimited allowance suggested by our Swap, but warn the users about it during transaction confirmation.

Test plan

For the QA steps, please try to reproduce the demo in the linked PR. Also try to test the following:

  • Approve an unlimited amount for a token, and verify the transaction on the blockchain.
  • Same as above, but for a smaller custom amount.
@onyb onyb added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Feb 18, 2022
@onyb onyb self-assigned this Feb 18, 2022
@onyb onyb added this to the 1.37.x - Nightly milestone Feb 22, 2022
@kjozwiak
Copy link
Member

This will require 1.36.106 or newer.

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.36.106 Chromium: 99.0.4844.45 (Official Build) (64-bit)
Revision edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}
OS Linux
  • Verified test plan from issue description
  • Verified when Activating a token panel shows Unlimited allowance requested warning message
  • Verified able to change to custom allowance value
  • Verified once custom allowance value is set it never shows Unlimited allowance requested message again
  • Verified able to set to different custom value and approve transaction
21198.mp4

Confirmed with @onyb verification on one platform is sufficient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants