Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave News: re-enable peeking card on Android - follow up to #22135 #22778

Closed
kjozwiak opened this issue May 11, 2022 · 3 comments
Closed

Brave News: re-enable peeking card on Android - follow up to #22135 #22778

kjozwiak opened this issue May 11, 2022 · 3 comments

Comments

@kjozwiak
Copy link
Member

Description

Re-enable the peeking card on new tab page

This was disabled with #21477 for 1.36.x and via #22135 for 1.38.x due to #22569 & #22444.

Steps to reproduce

  1. Go to new tab page
  2. At the bottom, there should be a peeking card

QA STR/Cases can be found via brave/brave-core#13203 (comment). Specifically Test Case #1

Actual result

No peeking card

Expected result

Should be a peeking card you can swipe up and opt-in to Brave News

@kjozwiak
Copy link
Member Author

@brave/qa-team there's STR/Cases outlined via brave/brave-core#13203 (comment) regarding running through/ensuring that the opt-in card is working as expected via the NTP. Specifically Test Case #1 - Running through various opt-in scenarios This includes upgrades and installs.

@Uni-verse
Copy link
Contributor

Uni-verse commented May 16, 2022

Verification PASSED using version 1.38.118, Chromium 101.0.4951.67 on Samsung GS 21 on Android 12

STR/Test Scenarios - brave/brave-core#13203 (comment)

Clean install/Fresh Profile - PASS

  • Ensured opt-in card is displayed on new tab
  • Clicking on learn more will display privacy policy page
  • Able to dismiss opt-in card, relaunch browser doesn't bring it back
  • Able to enable brave news after dismissing opt-in card
  • Able to disable news after enabling
  • Brave news bar is shown when scrolling brave news
1 2 3 4
Screen Shot 2022-05-16 at 2 30 09 PM Screen Shot 2022-05-16 at 2 31 46 PM Screen Shot 2022-05-16 at 2 43 08 PM Screen Shot 2022-05-16 at 2 29 15 PM

Upgrading (Brave News not enabled) - PASS

  • Installed 1.38.113 and confirmed brave news was not enabled, upgraded to version 1.38.118 and ensured brave news is not enabled and opt-in card is displayed.
  • Enabling opt-in card will show brave news feed
  • Ensured user is able to dismiss opt in card and it doesn't show up again with relaunch / ntp.
  • Ensured user is able to enable news from menu after dismissing opt-in card.

Upgrading (Brave News enabled but then disabled by user) PASS

  • Installed 1.38.113, enabled brave news and confirmed news feed was displayed and then disable from menu.
  • Upgraded to 1.38.118 and confirmed brave news is not enabled.
  • User is abled to enable brave news from menu and news feed was displayed.
  • Ensured opt-in card was not displayed.

Upgrading (Brave News enabled & visible) PASS

  • Installed 1.38.113, enabled brave news and confirmed feed was displayed.
  • Upgraded profile to 1.38.118 and confirmed brave news was enabled.

@Uni-verse
Copy link
Contributor

Uni-verse commented May 16, 2022

Verification PASSED using version 1.38.118, Chromium 101.0.4951.67 on Samsung Tab S7 on Android 12

STR/Test Scenarios - brave/brave-core#13203 (comment)

Clean install/Fresh Profile - PASS

  • Ensured opt-in card is displayed on new tab
  • Clicking on learn more will display privacy policy page
  • Able to dismiss opt-in card, relaunch browser doesn't bring it back
  • Able to enable brave news after dismissing opt-in card
  • Able to disable news after enabling
  • Brave news bar is shown when scrolling brave news
  • Opt-in card is disabled in both device orientations
  • Brave news in multiple windows
Full Opt-in Card Show News News Feed Peeking Card 2 windows on Tablet
Screen Shot 2022-05-16 at 3 37 08 PM Screen Shot 2022-05-16 at 3 37 20 PM Screen Shot 2022-05-16 at 3 38 24 PM Screen Shot 2022-05-16 at 3 36 54 PM Screen Shot 2022-05-16 at 3 46 31 PM

Upgrading (Brave News not enabled) - PASS

  • Installed 1.38.113 and confirmed brave news was not enabled, upgraded to version 1.38.118 and ensured brave news is not enabled and opt-in card is displayed.
  • Enabling opt-in card will show brave news feed
  • Ensured user is able to dismiss opt in card and it doesn't show up again with relaunch / ntp.
  • Ensured user is able to enable news from menu after dismissing opt-in card.

Upgrading (Brave News enabled but then disabled by user) - PASS

  • Installed 1.38.113, enabled brave news and confirmed news feed was displayed and then disable from menu.
  • Upgraded to 1.38.118 and confirmed brave news is not enabled.
  • User is abled to enable brave news from menu and news feed was displayed.
  • Ensured opt-in card was not displayed.

Upgrading (Brave News enabled & visible) PASS

Installed 1.38.113, enabled brave news and confirmed feed was displayed.
Upgraded profile to 1.38.118 and confirmed brave news was enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants