Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On custom asset dialog, some fields seem to be populating using previous attempts #23358

Closed
HEagle18 opened this issue Jun 9, 2022 · 2 comments
Labels
bug closed/not-actionable feature/web3/wallet Integrating Ethereum+ wallet support needs-investigation A bug not 100% confirmed/fixed OS/Desktop

Comments

@HEagle18
Copy link

HEagle18 commented Jun 9, 2022

Description

From customer at https://community.brave.com/t/wallet-asset-token-management-ordering-view/399725

''I also encountered a few bugs in the add custom asset dialog. When a network is selected and then a token contract inserted, other fields would often be filled out/overwritten from a previous add custom asset attempt.
Brave version 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64) on macOS 12.4''

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@HEagle18 HEagle18 added bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Jun 9, 2022
@HEagle18 HEagle18 added this to Web3 Jun 9, 2022
@jamesmudgett jamesmudgett added the needs-investigation A bug not 100% confirmed/fixed label Jun 17, 2022
@jamesmudgett
Copy link

@srirambv

@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jun 17, 2022
@srirambv
Copy link
Contributor

srirambv commented Jul 5, 2022

Sorry for the delay but seems like the issue is still reproducible on 1.40.109 however this seems fixed on 1.41.x and 1.42.x. So I'd close the issue for now and maybe reopen if we start receiving complaints on 1.41.x This is/was actually a regression of #21337 on 1.40.x

@srirambv srirambv closed this as completed Jul 5, 2022
Repository owner moved this from Backlog to Done in Web3 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/not-actionable feature/web3/wallet Integrating Ethereum+ wallet support needs-investigation A bug not 100% confirmed/fixed OS/Desktop
Projects
Archived in project
Development

No branches or pull requests

3 participants