Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DApps: Wallet icon should match the lock icon in the url bar at runtime #23632

Closed
Pavneet-Sing opened this issue Jun 23, 2022 · 1 comment · Fixed by brave/brave-core#13945
Closed

DApps: Wallet icon should match the lock icon in the url bar at runtime #23632

Pavneet-Sing opened this issue Jun 23, 2022 · 1 comment · Fixed by brave/brave-core#13945
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.42.x - Release

Comments

@Pavneet-Sing
Copy link

On sites changes the color of lock icon in the url bar at runtime so wallet icon should match the lock icon color.

wallet-icon.mp4
@Pavneet-Sing Pavneet-Sing added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality feature/web3/wallet/dapps labels Jun 23, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Jun 23, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Jun 23, 2022
Closed
3 tasks
@Pavneet-Sing Pavneet-Sing changed the title DApps: Wallet icon should match the lock icon in the url bar DApps: Wallet icon should match the lock icon in the url bar at runtime Jun 23, 2022
@Pavneet-Sing Pavneet-Sing moved this to In Progress in Web3 Jun 23, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Jun 24, 2022
Merged
25 tasks
Repository owner moved this from In Progress to Done in Web3 Jun 24, 2022
@brave-builds brave-builds added this to the 1.42.x - Nightly milestone Jun 24, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Jun 24, 2022
Closed
7 tasks
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.42.76 x64 Beta build

Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
23632-ARM.mp4
23632-Tab.mp4

@srirambv srirambv mentioned this issue Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.42.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): change wallet icon colour per website theme brave/brave-core
4 participants
@Pavneet-Sing @SergeyZhukovsky @srirambv @brave-builds