Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tipping banner should be non-modal, i.e. make it easily dismissable on clicking outside of the banner #23740

Closed
jenn-rhim opened this issue Jun 28, 2022 · 3 comments · Fixed by brave/brave-core#17647
Closed

Tipping banner should be non-modal, i.e. make it easily dismissable on clicking outside of the banner #23740

jenn-rhim opened this issue Jun 28, 2022 · 3 comments · Fixed by brave/brave-core#17647
Assignees
@emerick @zenparsing
Labels
feature/P2P-Send feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.52.x - Release

Comments

@jenn-rhim
Copy link

Currently the banner can be dismissed only when the user clicks the close button. This behavior is not originally intended nor necessary. We'd want to make this less friction as possible.

@Miyayes @zenparsing
@jenn-rhim jenn-rhim added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 28, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented Jun 28, 2022

Was filed in this issue a long time ago #1743. Will use this new, fresher issue instead!

@Miyayes Miyayes mentioned this issue Jun 28, 2022
Closed
@Miyayes Miyayes added the priority/P4 Planned work. We expect to get to it "soon". label Jun 29, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented Aug 3, 2022

Rewards client team is exploring lift weight. May require use of new Chromium abstraction, which is non-trivial.

@Miyayes Miyayes added priority/P3 The next thing for us to work on. It'll ride the trains. feature/P2P-Send and removed priority/P4 Planned work. We expect to get to it "soon". labels Jan 31, 2023
@Miyayes Miyayes removed the OS/Android Fixes related to Android browser functionality label Jan 31, 2023
@Miyayes
Copy link
Collaborator

Miyayes commented Feb 1, 2023

Currently a Chromium dialog. Will try to see if we can make it a Chromium bubble.

@Miyayes Miyayes mentioned this issue Mar 13, 2023
Closed
@zenparsing zenparsing mentioned this issue Mar 28, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

@zenparsing zenparsing

Labels
feature/P2P-Send feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

Tipping Banner 3.0 brave/brave-core
5 participants
@jenn-rhim @emerick @zenparsing @Miyayes @brave-builds