Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to native token when network is changed on Dapps Panel #24078

Closed
Pavneet-Sing opened this issue Jul 15, 2022 · 1 comment · Fixed by brave/brave-core#14201
Closed

Update to native token when network is changed on Dapps Panel #24078

Pavneet-Sing opened this issue Jul 15, 2022 · 1 comment · Fixed by brave/brave-core#14201
Assignees
@wchen342
Labels
bug feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.43.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Jul 15, 2022 •
edited
Loading

Description

The same fix brave/brave-core#14085 also needs to be applied on the panel as well as reported earlier and now.

panel-eth-issue

cc: @wchen342
@Pavneet-Sing Pavneet-Sing added bug priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality feature/web3/wallet/dapps labels Jul 15, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Jul 15, 2022
Closed
@wchen342 wchen342 mentioned this issue Jul 15, 2022
Merged
25 tasks
@wchen342 wchen342 moved this to Done in Web3 Jul 15, 2022
@wchen342 wchen342 added this to the 1.43.x - Nightly milestone Jul 15, 2022
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.43.74 x64 Beta build

  • Verified steps from brave/brave-core#14201
  • Verified when network is changed in panel corresponding network's native token is shown and balance is updated
Oppo Reno 5(Android 12) Samsung Tab A (Android 10)
24078-ARM.mp4
24078-Tab.mp4

@kjozwiak kjozwiak mentioned this issue Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wchen342 wchen342

Labels
bug feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.43.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] Dapps panel - select native asset on network change brave/brave-core
3 participants
@wchen342 @Pavneet-Sing @srirambv