Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly import the types from window.crypto.randomUUID #24764

Open
kdenhartog opened this issue Aug 18, 2022 · 0 comments
Open

properly import the types from window.crypto.randomUUID #24764

kdenhartog opened this issue Aug 18, 2022 · 0 comments
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/exclude

Comments

@kdenhartog
Copy link
Member

It looks like the typing in the wallet for this function appears to be inferred from VS Code's lib.dom.d.ts file which is the reason the type never appears when compiling but seems fine in VS Code. To refactor this we could import this type file directly where this is used so that we no longer have to define the type each time this is getting used.

See here for additional details: brave/brave-core#14373 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kdenhartog