Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean URLs - Rework the brave_site_hacks_network_delegate_helper code to use URL Sanitizer service #25104

Open
bsclifton opened this issue Aug 31, 2022 · 0 comments
Open

Clean URLs - Rework the brave_site_hacks_network_delegate_helper code to use URL Sanitizer service #25104

bsclifton opened this issue Aug 31, 2022 · 0 comments
Labels
dev-concern OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/query-filter

Comments

@bsclifton
Copy link
Member

Description

Follow up to brave/brave-core#14763 (phase 1)

There is some code (which is now duplicated) which we can clean up. It can be found here:
https://github.com/brave/brave-core/blob/d2d6b59666afa92b26e8c207ee936aad0a1c19f1/browser/net/brave_site_hacks_network_delegate_helper.cc#L74-L108

The list this code uses can be addressed by #10188 (phase 5)... but the code itself can make use of URLSanitizerService::StripQueryParameter and the older code in brave_site_hacks_network_delegate_helper.cc can be removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-concern OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/query-filter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bsclifton