Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NFT tab #25245

Closed
muliswilliam opened this issue Sep 7, 2022 · 1 comment · Fixed by brave/brave-core#15013
Closed

Add NFT tab #25245

muliswilliam opened this issue Sep 7, 2022 · 1 comment · Fixed by brave/brave-core#15013
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.45.x - Release

Comments

@muliswilliam
Copy link

muliswilliam commented Sep 7, 2022 •
edited
Loading

Add a new tab with NFT assets in a grid with a search and network filter
@muliswilliam muliswilliam self-assigned this Sep 7, 2022
@muliswilliam muliswilliam moved this from Backlog to In Review in Web3 Sep 7, 2022
@muliswilliam muliswilliam mentioned this issue Sep 7, 2022
Merged
25 tasks
Repository owner moved this from In Review to Done in Web3 Sep 8, 2022
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Sep 8, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Linux
  • Verified steps from brave/brave-core#15013
  • Verified a new NFT tab is available
  • Verified all NFT's added to wallet is listed
  • Verified able to filter NFT's by network
  • Verified clicking on the NFT loads the NFT details page
  • Verified clicking on the magnifier icon on the NFT shows a bigger version of NFT image
  • Encountered #26064
25245.mp4

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Windows 11 Version 21H2 (Build 22000.978)
  • Verified steps from brave/brave-core#15013
  • Verified a new NFT tab is available
  • Verified all NFT's added to wallet is listed
  • Verified able to filter NFT's by network
  • Verified clicking on the NFT loads the NFT details page
  • Verified clicking on the magnifier icon on the NFT shows a bigger version of NFT image
  • Encountered #26064
25245.mp4

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (arm64)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from brave/brave-core#15013
  • Verified a new NFT tab is available
  • Verified all NFT's added to wallet is listed
  • Verified able to filter NFT's by network
  • Verified clicking on the NFT loads the NFT details page
  • Verified clicking on the magnifier icon on the NFT shows a bigger version of NFT image
  • Encountered #26064
25245.mov

@srirambv srirambv mentioned this issue Oct 17, 2022
Closed
@LaurenWags LaurenWags mentioned this issue Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.45.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Add NFT Tab brave/brave-core
3 participants
@srirambv @brave-builds @muliswilliam