disable the ability to dismiss the cookie consent modal via outside-click

[kjozwiak]

Description

We should disable the ability to dismiss the cookie consent modal by clicking anywhere outside the modal. In it's current state, the modal is very flaky in terms of users accidentally clicking anywhere within the browser before reading/interacting with the modal. The other case is when the modal appears but is interrupted by another modal/prompt or interaction, the cookie consent modal is also dismissed. Because we only display it once, if a user accidentally misses the cookie consent modal, they'll never get the chance to make a decision again unless they go into brave://settings/shields/filters. This affects both Desktop & Android.

Some context/discussion available via https://bravesoftware.slack.com/archives/CKNHM4RTK/p1664405692434979.

Information/more context:

• Desktop - currently in 1.44.x, 1.45.x & 1.46.x but behind a flag as per Add dialog to surface the setting for blocking cookie consent banners #10433
• Android - currently in 1.46 only via [Android] Cookie banner blocker #8974
• P3A associated with the cookie consent only in 1.46.x as per Add cookie consent notice blocking P3A metrics #25568
• Griffin - enabled on production via Push Cookie-List opt-in bubble to Nightly (production) brave-variations#330
• Griffin - QA'd/verified on staging via Add Android to BraveAdblockCookieListOptInStudy on main brave-variations#377 (comment) & Add Android to BraveAdblockCookieListOptInStudy on main brave-variations#377 (comment).

Steps to Reproduce

Desktop Case

1. launch Nightly via new profile
2. restart the browser and you should see the cookie consent modal (applies the Griffin studies that were pulled at first launch)
3. click anywhere within Brave and the modal will dismiss

Android Case

1. launch Nightly via new profile
2. restart the browser (applies the Griffin studies that were pulled at first launch)
3. visit any random website and refresh it 5 times (should see the cookie consent modal after five refreshes/loads)
4. tap anywhere on the screen and the modal will get dismissed

You can also enable the cookie consent modal via brave://flags/#brave-adblock-cookie-list-opt-in. However, it's currently enabled on Nightly via Griffin at 100% via brave/brave-variations#330.

Actual result:

Cookie consent modal is easily dismissed when clicking anywhere outside the modal while it's visible. Also dismisses if there's any other type of UI/UX interaction that occurs while the modal is visible.

Expected result:

User should be the one that dismisses the cookie consent modal. This way, they have the chance to read through it and decide to either enable the feature or dismiss the modal.

Reproduces how often:

Desktop Brave version:

Brave | 1.46.18 Chromium: 106.0.5249.65 (Official Build) nightly (64-bit)
-- | --
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS | Windows 11 Version 22H2 (Build 22621.521)

Android Device details:

• Install type (ARM, x86): ARM
• Device type (Phone, Tablet, Phablet): Pixel 6 (Phone)
• Android version: Android 13

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A (behind a flag and not enabled via Griffin)
• Can you reproduce this issue with the beta channel? N/A (behind a flag and not enabled via Griffin)
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

[kjozwiak]

Removed the OS/Android label as this only fixes the Desktop implementation. @deeppandya is working on the Android fix. @brave/qa-team you can find the STR/Cases via brave/brave-core#15286 (comment).

[kjozwiak]

The above will require 1.44.107 or higher for 1.44.x verification 👍

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.44.108 Chromium: 106.0.5249.103 (Official Build) (64-bit)
-- | --
Revision | 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS | Windows 10 Version 21H2 (Build 19044.2006)

• Reproduced the issue in 1.44.105 - click anywhere outside the cookies consent modal dismiss the modal
• Installed 1.44.108 and ensured the following checks:

Closing the Cookie Consent panel

• ensured switching tabs closes the cookie consent panel without any issues
• ensured closing the active tab closes the cookie consent panel without any issues
• ensured opening a new tab closes the cookie consent panel without any issues
• ensured that pressing the X closes the cookie consent panel without any issues
• ensured that clicking on No thanks closes the cookie consent panel without any issues

For each of the above cases, also ensured that the Easylist - Cookie List wasn't being enabled via brave://settings/shields/filters.

Accepting the Cookie Consent panel

• ensured that clicking on Yes, block cookie consent notices displayed the animation via the panel
  • ensured that the Easylist - Cookie List was enabled via brave://settings/shields/filters.
• ensured that pressing the X via the panel while the animation is in progress doesn't cause any visible issues
  • ensured that the Easylist - Cookie List was enabled via brave://settings/shields/filters.
• ensured that the animation doesn't cause any visible performance issues while it's in progress before the panel closes