Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a toggle to hide the price graph in Brave Wallet Portfolio Overview page #26080

Closed
josheleonard opened this issue Oct 17, 2022 · 1 comment · Fixed by brave/brave-core#15494
Closed

Add a toggle to hide the price graph in Brave Wallet Portfolio Overview page #26080

josheleonard opened this issue Oct 17, 2022 · 1 comment · Fixed by brave/brave-core#15494
Assignees
@josheleonard
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.47.x - Release

Comments

@josheleonard
Copy link

Description

Add a toggle button to show/hide the graph in the portfolio overview page

Figma prototype: https://www.figma.com/proto/CPUOGNxaQXHheUMoucwQFN/Portfolio?page-id=966%3A29147&node-id=1076%3A52452&viewport=5490%2C301%2C0.45&scaling=min-zoom&starting-point-node-id=1076%3A51546&show-proto-sidebar=1
@josheleonard josheleonard added OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Oct 17, 2022
@josheleonard josheleonard self-assigned this Oct 17, 2022
@josheleonard josheleonard mentioned this issue Oct 18, 2022
Merged
25 tasks
@josheleonard josheleonard moved this to Done in Web3 Oct 19, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Oct 19, 2022
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Dec 2, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (64-bit)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS Linux
  • Verified steps from brave/brave-core#15494
  • Verified toggle next to portfolio balance shows/hide portfolio balance and tokens balance
  • Verified toggle on token details screen shows/hides balance
26080.mp4

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (64-bit)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#15494
  • Verified toggle next to portfolio balance shows/hide portfolio balance and tokens balance
  • Verified toggle on token details screen shows/hides balance
26080.mp4

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (arm64)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#15494
  • Verified toggle next to portfolio balance shows/hide portfolio balance and tokens balance
  • Verified toggle on token details screen shows/hides balance
26080.mov

@LaurenWags LaurenWags mentioned this issue Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

feat: add portfolio graph visibility toggle button brave/brave-core
4 participants
@srirambv @LaurenWags @josheleonard @brave-builds